[GitHub] [commons-lang] GedMarc edited a comment on issue #299: Add module-info for Java 9

[GitBox <gi...@apache.org>]

GedMarc edited a comment on issue #299: Add module-info for Java 9
URL: https://github.com/apache/commons-lang/pull/299#issuecomment-483881536
 
 
   @jodastephen @jfallows 
   I have successfully managed to get moditect on lang3, io, fileupload and text - 
   
   https://github.com/GedMarc/commons-lang
   https://github.com/GedMarc/commons-io
   https://github.com/GedMarc/commons-fileupload
   
   Using source and target of 1.6 is still supported to build for that target JDK (I have done this successfully with the org.json project), however the actual build has to happen in JDK 8 for the plugin to work.
   
   When building the module-info, no import statements are allowed as yet
   
   I place them directly in the root, @ClassGraph (Duke Choice Winner), places the module info files in the meta-inf/versions/ correctly with moditect. He also participates in the moditect development.
   
   https://github.com/GedMarc/commons-lang/blob/master/src/jre11/java/module-info.java
   https://github.com/GedMarc/commons-fileupload/blob/master/src/jre11/java/module-info.java
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services