You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/17 16:59:29 UTC
[kudu-CR] test: fix HMS plugin test
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15747
Change subject: test: fix HMS plugin test
......................................................................
test: fix HMS plugin test
Running TestKuduMetastorePlugin with a version of Hive that includes
3ab174d82ffc2bd27432c0b04433be3bd7db5c6a raises a different exception
than expected. This patch changes the test to set an appropiate location
for Hive tables.
Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 54 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/15747/1
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] test: fix HMS plugin test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15747 )
Change subject: test: fix HMS plugin test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15747/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/15747/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@357
PS1, Line 357: MetastoreDefaultTransformer validation
Can you elaborate on when this validation will be triggered and what does it expect either here or in the commit msg?
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 18:07:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] test: fix HMS plugin test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15747 )
Change subject: test: fix HMS plugin test
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 20:46:32 +0000
Gerrit-HasComments: No
[kudu-CR] test: fix HMS plugin test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15747 )
Change subject: test: fix HMS plugin test
......................................................................
test: fix HMS plugin test
Running TestKuduMetastorePlugin with a version of Hive that includes
3ab174d82ffc2bd27432c0b04433be3bd7db5c6a raises a different exception
than expected. This patch changes the test to set an appropiate location
for Hive tables.
Such a version of hive would yield errors like:
08:56:19.427 [ERROR - pool-11-thread-2] (RetryingHMSHandler.java:201) MetaException(message:An external table's location should not be located within managed warehouse root directory, table:table,location:/tmp/hive6879897156513669203/warehouse/table,managed warehouse:/tmp/hive6879897156513669203/warehouse)
...indicating the need for us to denote a different location. I went
with the location used in d96f8fca55, which fixed a similar issue.
Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Reviewed-on: http://gerrit.cloudera.org:8080/15747
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 54 insertions(+), 20 deletions(-)
Approvals:
Grant Henke: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] test: fix HMS plugin test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15747 )
Change subject: test: fix HMS plugin test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 22:03:00 +0000
Gerrit-HasComments: No
[kudu-CR] test: fix HMS plugin test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15747
to look at the new patch set (#2).
Change subject: test: fix HMS plugin test
......................................................................
test: fix HMS plugin test
Running TestKuduMetastorePlugin with a version of Hive that includes
3ab174d82ffc2bd27432c0b04433be3bd7db5c6a raises a different exception
than expected. This patch changes the test to set an appropiate location
for Hive tables.
Such a version of hive would yield errors like:
08:56:19.427 [ERROR - pool-11-thread-2] (RetryingHMSHandler.java:201) MetaException(message:An external table's location should not be located within managed warehouse root directory, table:table,location:/tmp/hive6879897156513669203/warehouse/table,managed warehouse:/tmp/hive6879897156513669203/warehouse)
...indicating the need for us to denote a different location. I went
with the location used in d96f8fca55, which fixed a similar issue.
Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 54 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/15747/2
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] test: fix HMS plugin test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15747 )
Change subject: test: fix HMS plugin test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15747/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/15747/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@357
PS1, Line 357: MetastoreDefaultTransformer validation
> Can you elaborate on when this validation will be triggered and what does i
Done
--
To view, visit http://gerrit.cloudera.org:8080/15747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ea8e3d6f2513f6ec3439b2e947e3564c4c53590
Gerrit-Change-Number: 15747
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 17 Apr 2020 20:40:29 +0000
Gerrit-HasComments: Yes