You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2011/03/24 16:24:05 UTC

[jira] [Created] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

add system test using multiple producers with batched transactions and multiple consumers with unique selectors
---------------------------------------------------------------------------------------------------------------

                 Key: QPID-3166
                 URL: https://issues.apache.org/jira/browse/QPID-3166
             Project: Qpid
          Issue Type: Sub-task
          Components: Java Tests
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
             Fix For: 0.11


Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011988#comment-13011988 ] 

Robbie Gemmell commented on QPID-3166:
--------------------------------------

Updated based on review.

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-3166:
------------------------------------

    Assignee: Robbie Gemmell  (was: Keith Wall)

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3166.
----------------------------------

    Resolution: Fixed

Closing out old issue.

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-3166:
------------------------------------

    Assignee: Keith Wall  (was: Robbie Gemmell)

Hi Keith, can you review please? Thanks.

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3166:
-----------------------------

    Status: Open  (was: Ready To Review)

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3166:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3166:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3166) add system test using multiple producers with batched transactions and multiple consumers with unique selectors

Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011975#comment-13011975 ] 

Keith Wall commented on QPID-3166:
----------------------------------

Hi Robbie

Looks good, just a couple of comments.

1) You don't explain why it is necessary to bias the distribution of the messages.
2) Thread safety issue with _failMsg means we might fail to see the assertNull when we should. I see that latch will still mean the test fail but the threading issue might obscure the underlying cause. Making _failMsg volatile (or atomicref) would be resolve the issue.
3) I think your javadoc would be better moved down to method level rather than class level.

> add system test using multiple producers with batched transactions and multiple consumers with unique selectors
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3166
>                 URL: https://issues.apache.org/jira/browse/QPID-3166
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Tests
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>             Fix For: 0.11
>
>
> Add system test using multiple producers with batched transactions and multiple consumers with unique selectors

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org