You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Don Brown (JIRA)" <ji...@apache.org> on 2006/07/26 05:03:21 UTC

[jira] Updated: (WW-493) Refactor Configuration classes

     [ http://issues.apache.org/struts/browse/WW-493?page=all ]

Don Brown updated WW-493:
-------------------------

    Fix Version/s: 2.0.1
                       (was: 2.0.0)
         Assignee: Don Brown  (was: Jason Carreira)

Yeah, this is going to take some more thought.  For now, I changed Configuration to only deal with Strings, since that is all it is used for anyways.  Moving to 2.0.1...

> Refactor Configuration classes
> ------------------------------
>
>                 Key: WW-493
>                 URL: http://issues.apache.org/struts/browse/WW-493
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Bill Lynch
>         Assigned To: Don Brown
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> The Configuration classes (see com\opensymphony\webwork\config\*.java) are poorly designed and should be refactored.
> Suggestions:
> 1) Are there XWork classes we can use? Seems like the XWork configs should be flexible enough to say something like "here are my config files, use them...".
> 2) Move webwork.config.XMLActionConfiguration to com.opensymphony.webwork.config.XMLActionConfiguration -- or use the XWork XML config stuff (seems like it should be taken care of in there?). I don't know why that class is in the webwork.config (old) package when it's pretty integral to everything.
> 3) Make Configuration abstract and fold in DefaultConfiguration into it. There is no reason to have all the *Impl(..) methods when the class should just be abstract anyway. All the code used in DefaultConfiguration can be easily moved into Configuration.
> 4) Remove get(String) method that returns an object. Is this even really used? We should just stipulate that a property is a String only.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira