You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ryan Sonnek (JIRA)" <ji...@apache.org> on 2007/03/06 03:35:24 UTC

[jira] Created: (WICKET-361) junit dependency should be marked as 'provided'

junit dependency should be marked as 'provided'
-----------------------------------------------

                 Key: WICKET-361
                 URL: https://issues.apache.org/jira/browse/WICKET-361
             Project: Wicket
          Issue Type: Bug
          Components: wicket
            Reporter: Ryan Sonnek
            Priority: Trivial
             Fix For: 2.0


the wicket pom has junit marked as a "compile" dependency.  This really isn't necessary, and isn't desired as this will cause wicket webapps to package junit in the war file.

{code:xml}
		<dependency>
			<groupId>junit</groupId>
			<artifactId>junit</artifactId>
			<version>3.8.1</version>
			<type>jar</type>
			<scope>compile</scope>
		</dependency>
{code}

Wicket provides the WicketTester code for projects, but junit should either be marked as "provided" or "optional" to get around this.  Another option would be to create a "wicket-tester" module so that users would have to explicitly add that dependency to use this junit dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-361) junit dependency should be marked as 'provided'

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot resolved WICKET-361.
-----------------------------------------

    Resolution: Won't Fix

The trunk branch has been replaced by version 1.3

> junit dependency should be marked as 'provided'
> -----------------------------------------------
>
>                 Key: WICKET-361
>                 URL: https://issues.apache.org/jira/browse/WICKET-361
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Ryan Sonnek
>            Priority: Trivial
>             Fix For: 2.0
>
>
> the wicket pom has junit marked as a "compile" dependency.  This really isn't necessary, and isn't desired as this will cause wicket webapps to package junit in the war file.
> {code:xml}
> 		<dependency>
> 			<groupId>junit</groupId>
> 			<artifactId>junit</artifactId>
> 			<version>3.8.1</version>
> 			<type>jar</type>
> 			<scope>compile</scope>
> 		</dependency>
> {code}
> Wicket provides the WicketTester code for projects, but junit should either be marked as "provided" or "optional" to get around this.  Another option would be to create a "wicket-tester" module so that users would have to explicitly add that dependency to use this junit dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-361) junit dependency should be marked as 'provided'

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478331 ] 

Jean-Baptiste Quenot commented on WICKET-361:
---------------------------------------------

Actually I think trunk/wicket/pom.xml should be stripped down to the bare minimum.  See how it is currently in branches/wicket-1.x/wicket/pom.xml.  All dependencies are inherited from wicket-parent.

> junit dependency should be marked as 'provided'
> -----------------------------------------------
>
>                 Key: WICKET-361
>                 URL: https://issues.apache.org/jira/browse/WICKET-361
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Ryan Sonnek
>            Priority: Trivial
>             Fix For: 2.0
>
>
> the wicket pom has junit marked as a "compile" dependency.  This really isn't necessary, and isn't desired as this will cause wicket webapps to package junit in the war file.
> {code:xml}
> 		<dependency>
> 			<groupId>junit</groupId>
> 			<artifactId>junit</artifactId>
> 			<version>3.8.1</version>
> 			<type>jar</type>
> 			<scope>compile</scope>
> 		</dependency>
> {code}
> Wicket provides the WicketTester code for projects, but junit should either be marked as "provided" or "optional" to get around this.  Another option would be to create a "wicket-tester" module so that users would have to explicitly add that dependency to use this junit dependency.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.