You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JiahuiJiang <gi...@git.apache.org> on 2018/04/02 17:06:27 UTC
[GitHub] spark pull request #20961: [SPARK-23823][SQL] Keep origin in transformExpres...
GitHub user JiahuiJiang opened a pull request:
https://github.com/apache/spark/pull/20961
[SPARK-23823][SQL] Keep origin in transformExpression
Fixes https://issues.apache.org/jira/browse/SPARK-23823
Keep origin for all the methods using transformExpression
## What changes were proposed in this pull request?
Keep origin in transformExpression
## How was this patch tested?
Manually tested that this fixes https://issues.apache.org/jira/browse/SPARK-23823 and columns have correct origins after Analyzer.analyze
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JiahuiJiang/spark jj/keep-origin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20961
----
commit 5e8380558ddf104993e3ea0e7cd1d42c0639b60e
Author: JiahuiJiang <jj...@...>
Date: 2018-04-02T17:02:40Z
[SPARK-23823][SQL] Keep origin in transformExpression
Fixes https://issues.apache.org/jira/browse/SPARK-23823
Keep origin for all the methods using transformExpression
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by JiahuiJiang <gi...@git.apache.org>.
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@hvanhovell added a test, before this change the origin would be undefined
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88945/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88957/testReport)** for PR 20961 at commit [`a1c029c`](https://github.com/apache/spark/commit/a1c029ccd40219856f300af0d10e0220e96b6b03).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88831/testReport)** for PR 20961 at commit [`5e83805`](https://github.com/apache/spark/commit/5e8380558ddf104993e3ea0e7cd1d42c0639b60e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88831/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88909/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88952/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88952/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88954 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88954/testReport)** for PR 20961 at commit [`a1c029c`](https://github.com/apache/spark/commit/a1c029ccd40219856f300af0d10e0220e96b6b03).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88909/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class QueryPlanSuite extends SparkFunSuite `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88831/testReport)** for PR 20961 at commit [`5e83805`](https://github.com/apache/spark/commit/5e8380558ddf104993e3ea0e7cd1d42c0639b60e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by JiahuiJiang <gi...@git.apache.org>.
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@kiszk Added the ticket number! Do we need to retrigger the test build on that new commit?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88890/testReport)** for PR 20961 at commit [`8396dbb`](https://github.com/apache/spark/commit/8396dbb04c47f9ff05975260a5efc0eb9eaf65b9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20961
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88890 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88890/testReport)** for PR 20961 at commit [`8396dbb`](https://github.com/apache/spark/commit/8396dbb04c47f9ff05975260a5efc0eb9eaf65b9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88909/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20961
Can you add a test? Just show that origin is still the same after you transform the node.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20961
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20961
This sounds right to me. cc @hvanhovell @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20961
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88945/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class QueryPlanSuite extends SparkFunSuite `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20961
LGTM, too
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20961: [SPARK-23823][SQL] Keep origin in transformExpres...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20961#discussion_r178997765
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala ---
@@ -103,7 +103,7 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
var changed = false
@inline def transformExpression(e: Expression): Expression = {
- val newE = f(e)
+ val newE = CurrentOrigin.withOrigin(e.origin) { f(e) }
--- End diff --
Nit: style issue:
```Scala
val newE = CurrentOrigin.withOrigin(e.origin) {
f(e)
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88957/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20961: [SPARK-23823][SQL] Keep origin in transformExpres...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20961
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88954/testReport)** for PR 20961 at commit [`a1c029c`](https://github.com/apache/spark/commit/a1c029ccd40219856f300af0d10e0220e96b6b03).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88957/testReport)** for PR 20961 at commit [`a1c029c`](https://github.com/apache/spark/commit/a1c029ccd40219856f300af0d10e0220e96b6b03).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20961
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20961
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by JiahuiJiang <gi...@git.apache.org>.
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
Don't know why it failed so many times... but all these tests pass on my local machine and the commit before adding the test...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by JiahuiJiang <gi...@git.apache.org>.
Github user JiahuiJiang commented on the issue:
https://github.com/apache/spark/pull/20961
@gatorsmile fixed :D
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20961
**[Test build #88952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88952/testReport)** for PR 20961 at commit [`52e8875`](https://github.com/apache/spark/commit/52e8875f040a327c7045fdba3fbd4671690cb0c5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class QueryPlanSuite extends SparkFunSuite `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88945/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88890/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20961
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88954/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20961: [SPARK-23823][SQL] Keep origin in transformExpres...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20961#discussion_r179548494
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/QueryPlanSuite.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.plans
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.dsl.plans
+import org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression, Literal, NamedExpression}
+import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, Origin}
+import org.apache.spark.sql.types.IntegerType
+
+class QueryPlanSuite extends SparkFunSuite {
+
+ test("origin remains the same after mapExpressions") {
--- End diff --
nit: is it better to add JIRA number (i.e. `SPARK-PARK-23823: ...`)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org