You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2015/02/25 15:42:46 UTC

Re: svn commit: r1662227 - in /subversion/branches/svn-info-detail/subversion: svn/info-cmd.c tests/cmdline/info_tests.py

> URL: http://svn.apache.org/r1662227
> Log:
> On the svn-inf-detail branch: Make error messages more concise
> and consistent with other subcommands.

> @@ -878,13 +878,13 @@ svn_cl__info(apr_getopt_t *os,
>        receiver = print_info_xml;
> 
>        if (opt_state->show_item)
> -        return svn_error_create(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> -                                _("the 'show-item' option is not valid"
> -                                  " in XML mode"));
> +        return svn_error_create(
> +            SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> +            _("--show-item is not valid in --xml mode"));
>        if (opt_state->no_newline)
> -        return svn_error_create(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> -                                _("the 'no-newline' option is only valid"
> -                                  " with the 'show-item' option"));
> +        return svn_error_create(
> +            SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> +            _("--no-newline' is only valid with --show-item"));

This is in the 'if XML mode' code path. It shouldn't say 'only valid with --show-item', but instead 'not valid in XML mode' here.

[...]

- Julian