You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by James Carman <ja...@carmanconsulting.com> on 2013/10/08 22:33:56 UTC
Inconsistent Synchronization...
Team,
I was looking at Sonar and one particular rule violation stands out
(at least to me):
https://analysis.apache.org/drilldown/issues/37401?&rule=findbugs%3AIS2_INCONSISTENT_SYNC&rule_sev=CRITICAL&severity=CRITICAL
There are quite a few places within Camel where we inconsistently
access variables under synchronization. We should create JIRAs for
these and get them fixed.
Thoughts?
James
Re: Inconsistent Synchronization...
Posted by James Carman <ja...@carmanconsulting.com>.
Sonar is pretty good at detecting this stuff. I'd be surprised if it's a
false positive.
On Tuesday, October 8, 2013, Willem jiang wrote:
> It looks Sonar found some issues in the code.
> I just have a quick look at some of the Inconsistent Synchronization
> issues, I don't think it's the code problem.
>
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> Web: http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/)
> (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
>
>
> On Wednesday, October 9, 2013 at 5:44 AM, Christian Müller wrote:
>
> > +1
> >
> > Best,
> > Christian
> > -----------------
> >
> > Software Integration Specialist
> >
> > Apache Camel committer: https://camel.apache.org/team
> > V.P. Apache Camel: https://www.apache.org/foundation/
> > Apache Member: https://www.apache.org/foundation/members.html
> >
> > https://www.linkedin.com/pub/christian-mueller/11/551/642
> >
> >
> > On Tue, Oct 8, 2013 at 10:33 PM, James Carman <
> james@carmanconsulting.com <javascript:;> (mailto:
> james@carmanconsulting.com <javascript:;>)>wrote:
> >
> > > Team,
> > >
> > > I was looking at Sonar and one particular rule violation stands out
> > > (at least to me):
> > >
> > >
> > >
> https://analysis.apache.org/drilldown/issues/37401?&rule=findbugs%3AIS2_INCONSISTENT_SYNC&rule_sev=CRITICAL&severity=CRITICAL
> > >
> > > There are quite a few places within Camel where we inconsistently
> > > access variables under synchronization. We should create JIRAs for
> > > these and get them fixed.
> > >
> > > Thoughts?
> > >
> > > James
>
>
>
Re: Inconsistent Synchronization...
Posted by Willem jiang <wi...@gmail.com>.
It looks Sonar found some issues in the code.
I just have a quick look at some of the Inconsistent Synchronization issues, I don't think it's the code problem.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Wednesday, October 9, 2013 at 5:44 AM, Christian Müller wrote:
> +1
>
> Best,
> Christian
> -----------------
>
> Software Integration Specialist
>
> Apache Camel committer: https://camel.apache.org/team
> V.P. Apache Camel: https://www.apache.org/foundation/
> Apache Member: https://www.apache.org/foundation/members.html
>
> https://www.linkedin.com/pub/christian-mueller/11/551/642
>
>
> On Tue, Oct 8, 2013 at 10:33 PM, James Carman <james@carmanconsulting.com (mailto:james@carmanconsulting.com)>wrote:
>
> > Team,
> >
> > I was looking at Sonar and one particular rule violation stands out
> > (at least to me):
> >
> >
> > https://analysis.apache.org/drilldown/issues/37401?&rule=findbugs%3AIS2_INCONSISTENT_SYNC&rule_sev=CRITICAL&severity=CRITICAL
> >
> > There are quite a few places within Camel where we inconsistently
> > access variables under synchronization. We should create JIRAs for
> > these and get them fixed.
> >
> > Thoughts?
> >
> > James
Re: Inconsistent Synchronization...
Posted by Christian Müller <ch...@gmail.com>.
+1
Best,
Christian
-----------------
Software Integration Specialist
Apache Camel committer: https://camel.apache.org/team
V.P. Apache Camel: https://www.apache.org/foundation/
Apache Member: https://www.apache.org/foundation/members.html
https://www.linkedin.com/pub/christian-mueller/11/551/642
On Tue, Oct 8, 2013 at 10:33 PM, James Carman <ja...@carmanconsulting.com>wrote:
> Team,
>
> I was looking at Sonar and one particular rule violation stands out
> (at least to me):
>
>
> https://analysis.apache.org/drilldown/issues/37401?&rule=findbugs%3AIS2_INCONSISTENT_SYNC&rule_sev=CRITICAL&severity=CRITICAL
>
> There are quite a few places within Camel where we inconsistently
> access variables under synchronization. We should create JIRAs for
> these and get them fixed.
>
> Thoughts?
>
> James
>