You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/25 05:58:47 UTC
[GitHub] [flink] streaming-olap commented on a change in pull request #8751:
[FLINK-11937][StateBackend]Resolve small file problem in RocksDB
incremental checkpoint
streaming-olap commented on a change in pull request #8751: [FLINK-11937][StateBackend]Resolve small file problem in RocksDB incremental checkpoint
URL: https://github.com/apache/flink/pull/8751#discussion_r361260570
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -154,8 +160,12 @@ public RocksIncrementalSnapshotStrategy(
final SnapshotDirectory snapshotDirectory = prepareLocalSnapshotDirectory(checkpointId);
LOG.trace("Local RocksDB checkpoint goes to backup path {}.", snapshotDirectory);
+ if (this.checkpointStreamFactory == null) {
+ this.checkpointStreamFactory = checkpointStreamFactory;
Review comment:
The line 175 may use this.checkpointStreamFactory replace checkpointStreamFactory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services