[GitHub] [flink] danny0405 commented on a change in pull request #10493: [FLINK-15061][table]create/alter and table/databases properties should be case sensitive stored in catalog

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #10493: [FLINK-15061][table]create/alter and table/databases properties should be case sensitive stored in catalog
URL: https://github.com/apache/flink/pull/10493#discussion_r355349238
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/operations/SqlToOperationConverterTest.java
 ##########
 @@ -575,11 +584,15 @@ public void testAlterTable() throws Exception {
 			assertEquals(expectedNewIdentifier, alterTableRenameOperation.getNewTableIdentifier());
 		}
 		// test alter table properties
-		Operation operation = parse("alter table cat1.db1.tb1 set ('k1' = 'v1', 'k2' = 'v2')", SqlDialect.DEFAULT);
+		Operation operation = parse("alter table cat1.db1.tb1 set ('k1' = 'v1', 'K2' = 'V2')", SqlDialect.DEFAULT);
 		assert operation instanceof AlterTablePropertiesOperation;
 		final AlterTablePropertiesOperation alterTablePropertiesOperation = (AlterTablePropertiesOperation) operation;
 		assertEquals(expectedIdentifier, alterTablePropertiesOperation.getTableIdentifier());
 		assertEquals(2, alterTablePropertiesOperation.getCatalogTable().getProperties().size());
+		Map<String, String> properties = new HashMap<>();
+		properties.put("k1", "v1");
 
 Review comment:
   You can add new key-value pairs instead of modifying the existing ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services