You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/05/24 14:04:49 UTC

[GitHub] [incubator-eventmesh] SteveYurongSu opened a new pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

SteveYurongSu opened a new pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365


   See #364 for detail.
   
   > I'd like to add a step in CI to evaluate and report the code coverage, and use this as an opportunity to migrate the CI workflow from Travis CI to Github Actions.
   > 
   > Why do I want to migrate the CI workflow from Travis CI to Github Actions? There are several reasons:
   > 
   > The virtual machines that Travis CI provides to public repos to run CI are weaker than that of Github Actions. We have done some tests in the repo of Apache IoTDB, and the time spent on building executable files and running tests in Travis CI is significantly higher than the time spent on Github Actions.
   > 
   > Github Actions make it easier for the flok repos to run integration tests out of the Apache repo. There is a limited amount of runs that Travis CI allows individuals to trigger for free in a year, which causes some contributors (sadly, including me) to be unable to run CI in their own repos.
   > 
   > It is more convenient to build workflows using the Github Actions, which allows users to perform multiple checks in one build. We only need to build the code once to run ITs/UTs, perform CodeQL checks and update the code coverage in Codecov.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365#issuecomment-848695266


   ok, then i will close #310 and wait for your License Check actions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365#issuecomment-847083896


   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`develop@d599eea`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head e569d0e differs from pull request most recent head b3318fe. Consider uploading reports for the commit b3318fe to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/365/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             develop    #365   +/-   ##
   =========================================
     Coverage           ?   5.55%           
     Complexity         ?      85           
   =========================================
     Files              ?     118           
     Lines              ?    5310           
     Branches           ?     357           
   =========================================
     Hits               ?     295           
     Misses             ?    4973           
     Partials           ?      42           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/365?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/365?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d599eea...b3318fe](https://codecov.io/gh/apache/incubator-eventmesh/pull/365?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365#issuecomment-848545017


   Hi @qqeasonchen @xwm1992 , please review my PR and let me know if you have any questions. Thanks! 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365#issuecomment-848584947


   > Does Apache IOTDB transfer to Github Actions yet?
   
   Yep. 
   
   Actually Apache Dolphinscheduler, Apche IoTDB, Apache Skywalking... we all use GitHub Actions to run CI. GitHub Actions and Travis CI have no difference on running CI, but the GitHub Actions runs faster and is more friendly to contributors.
   
   In the future, I also intend to add new check items, including style check, license check, and more. With Github Actions, we only need to build our project once to perform all checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #365: [ISSUE #364] Migrate CI to Github Actions and enable code coverage report

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #365:
URL: https://github.com/apache/incubator-eventmesh/pull/365#issuecomment-848573074


   Does Apache IOTDB transfer to Github Actions yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org