You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/14 13:05:18 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
slinkydeveloper opened a new pull request #18755:
URL: https://github.com/apache/flink/pull/18755
This PR introduces a new API object called `TablePipeline` which encapsulates the description of an table pipeline, as a result of a compilation of an `INSERT INTO`. The implementation is simply a wrapper for `List<ModifyOperation>`. It also adds the method `StatementSet#add(TablePipeline)` to add a pipeline to a statement set.
In order to improve the overall design quality of our APIs, in the first commit I introduced 3 interfaces splitting the capabilities of our API components:
* `Compilable`: an object that can be compiled to a `CompiledPlan`
* `Explainable`: an object that can be explained
* `Executable`: an object that can be executed
This brings overall consistency to our APIs and improves documentation. This change is a refactoring and doesn't bring any new feature, except the fluent `printExplain` method.
The implementation of these capabilities is:
| | `Compilable` | `Executable` | `Explainable` |
|-----------------|--------------------|--------------------|--------------------|
| `Table` | FLINK-25843 | :heavy_check_mark: | :heavy_check_mark: |
| `StatementSet` | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
| `CompiledPlan` | Won't fix | To be discussed? | :heavy_check_mark: |
| `TablePipeline` | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
## Verifying this change
Added a test to verify a table pipeline can be compiled to a plan. The rest of the changes is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18755:
URL: https://github.com/apache/flink/pull/18755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18755:
URL: https://github.com/apache/flink/pull/18755#discussion_r806717186
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TablePipeline.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+/**
+ * This interface describes a pipeline created from a single {@code INSERT INTO} statement, created
+ * either using Table APIs or SQL.
+ */
+@PublicEvolving
+public interface TablePipeline extends Explainable<TablePipeline>, Executable, Compilable {}
Review comment:
I added both `getSinkIdentifier` and implemented `toString` in `TablePipelineImpl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18755:
URL: https://github.com/apache/flink/pull/18755#discussion_r806658241
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamStatementSet.java
##########
@@ -38,18 +40,26 @@
@PublicEvolving
public interface StreamStatementSet extends StatementSet {
+ /** {@inheritDoc} */
Review comment:
This should actually not be necessary. I remember that I also did some research. Did you verify this with IntelliJ?
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TablePipeline.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+/**
+ * This interface describes a pipeline created from a single {@code INSERT INTO} statement, created
+ * either using Table APIs or SQL.
+ */
+@PublicEvolving
+public interface TablePipeline extends Explainable<TablePipeline>, Executable, Compilable {}
Review comment:
to fill this interface with something useful. how about we provide an `ObjectIdentifier` for the sink table.
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamStatementSet.java
##########
@@ -38,18 +40,26 @@
@PublicEvolving
public interface StreamStatementSet extends StatementSet {
+ /** {@inheritDoc} */
@Override
StreamStatementSet addInsertSql(String statement);
+ /** {@inheritDoc} */
@Override
+ StreamStatementSet add(TablePipeline tablePipeline);
Review comment:
nit: add it to the end of all `insert` methods or to the beginning
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetPath: String, table: Table): StreamStatementSet = {
+ override def add(tablePipeline: TablePipeline): StreamStatementSet =
+ super.add(tablePipeline).asInstanceOf[StreamStatementSet]
+
+ override def addInsert(targetPath: String, table: Table): StreamStatementSet =
super.addInsert(targetPath, table).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(
- targetPath: String,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ override def addInsert(targetPath: String, table: Table, overwrite: Boolean): StreamStatementSet =
super.addInsert(targetPath, table, overwrite).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet = {
+ override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet =
super.addInsert(targetDescriptor, table).asInstanceOf[StreamStatementSet]
- }
override def addInsert(
- targetDescriptor: TableDescriptor,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ targetDescriptor: TableDescriptor,
+ table: Table,
+ overwrite: Boolean)
+ : StreamStatementSet =
super.addInsert(targetDescriptor, table, overwrite).asInstanceOf[StreamStatementSet]
+
+ override def printExplain(extraDetails: ExplainDetail*): StreamStatementSet = {
+ System.out.println(super.explain(extraDetails: _*))
Review comment:
Scala offers `println()` without `System.out`
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java
##########
@@ -95,7 +96,19 @@ public void testExecutePlan() throws Exception {
}
@Test
- public void testExecutePlanSql() throws Exception {
+ public void testExecutePlanTable() throws Exception {
+ List<String> data = Arrays.asList("1,1,hi", "2,1,hello", "3,2,hello world");
Review comment:
use constants above
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetPath: String, table: Table): StreamStatementSet = {
+ override def add(tablePipeline: TablePipeline): StreamStatementSet =
+ super.add(tablePipeline).asInstanceOf[StreamStatementSet]
+
+ override def addInsert(targetPath: String, table: Table): StreamStatementSet =
super.addInsert(targetPath, table).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(
- targetPath: String,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ override def addInsert(targetPath: String, table: Table, overwrite: Boolean): StreamStatementSet =
super.addInsert(targetPath, table, overwrite).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet = {
+ override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet =
super.addInsert(targetDescriptor, table).asInstanceOf[StreamStatementSet]
- }
override def addInsert(
- targetDescriptor: TableDescriptor,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ targetDescriptor: TableDescriptor,
Review comment:
fix indention
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
Review comment:
nit: IMHO we should leave curly braces for methods, we don't need to use very fancy Scala syntax, if you would add another statement, you would add the statement to the class init, pretty dangerous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18755:
URL: https://github.com/apache/flink/pull/18755#discussion_r806717186
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TablePipeline.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+/**
+ * This interface describes a pipeline created from a single {@code INSERT INTO} statement, created
+ * either using Table APIs or SQL.
+ */
+@PublicEvolving
+public interface TablePipeline extends Explainable<TablePipeline>, Executable, Compilable {}
Review comment:
I added both `getSinkIdentifier` and implemented `toString` in `TablePipelineImpl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "3fa76f668f123a0dbf4d09c1c73da522fce16ed2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fa76f668f123a0dbf4d09c1c73da522fce16ed2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* 3fa76f668f123a0dbf4d09c1c73da522fce16ed2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18755:
URL: https://github.com/apache/flink/pull/18755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039067515
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cbd78cd85cfd9d2791fba1c255cad43fe0857738 (Mon Feb 14 13:09:50 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18755:
URL: https://github.com/apache/flink/pull/18755#discussion_r806658241
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamStatementSet.java
##########
@@ -38,18 +40,26 @@
@PublicEvolving
public interface StreamStatementSet extends StatementSet {
+ /** {@inheritDoc} */
Review comment:
This should actually not be necessary. I remember that I also did some research. Did you verify this with IntelliJ?
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TablePipeline.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+/**
+ * This interface describes a pipeline created from a single {@code INSERT INTO} statement, created
+ * either using Table APIs or SQL.
+ */
+@PublicEvolving
+public interface TablePipeline extends Explainable<TablePipeline>, Executable, Compilable {}
Review comment:
to fill this interface with something useful. how about we provide an `ObjectIdentifier` for the sink table.
##########
File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamStatementSet.java
##########
@@ -38,18 +40,26 @@
@PublicEvolving
public interface StreamStatementSet extends StatementSet {
+ /** {@inheritDoc} */
@Override
StreamStatementSet addInsertSql(String statement);
+ /** {@inheritDoc} */
@Override
+ StreamStatementSet add(TablePipeline tablePipeline);
Review comment:
nit: add it to the end of all `insert` methods or to the beginning
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetPath: String, table: Table): StreamStatementSet = {
+ override def add(tablePipeline: TablePipeline): StreamStatementSet =
+ super.add(tablePipeline).asInstanceOf[StreamStatementSet]
+
+ override def addInsert(targetPath: String, table: Table): StreamStatementSet =
super.addInsert(targetPath, table).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(
- targetPath: String,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ override def addInsert(targetPath: String, table: Table, overwrite: Boolean): StreamStatementSet =
super.addInsert(targetPath, table, overwrite).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet = {
+ override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet =
super.addInsert(targetDescriptor, table).asInstanceOf[StreamStatementSet]
- }
override def addInsert(
- targetDescriptor: TableDescriptor,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ targetDescriptor: TableDescriptor,
+ table: Table,
+ overwrite: Boolean)
+ : StreamStatementSet =
super.addInsert(targetDescriptor, table, overwrite).asInstanceOf[StreamStatementSet]
+
+ override def printExplain(extraDetails: ExplainDetail*): StreamStatementSet = {
+ System.out.println(super.explain(extraDetails: _*))
Review comment:
Scala offers `println()` without `System.out`
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java
##########
@@ -95,7 +96,19 @@ public void testExecutePlan() throws Exception {
}
@Test
- public void testExecutePlanSql() throws Exception {
+ public void testExecutePlanTable() throws Exception {
+ List<String> data = Arrays.asList("1,1,hi", "2,1,hello", "3,2,hello world");
Review comment:
use constants above
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetPath: String, table: Table): StreamStatementSet = {
+ override def add(tablePipeline: TablePipeline): StreamStatementSet =
+ super.add(tablePipeline).asInstanceOf[StreamStatementSet]
+
+ override def addInsert(targetPath: String, table: Table): StreamStatementSet =
super.addInsert(targetPath, table).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(
- targetPath: String,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ override def addInsert(targetPath: String, table: Table, overwrite: Boolean): StreamStatementSet =
super.addInsert(targetPath, table, overwrite).asInstanceOf[StreamStatementSet]
- }
- override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet = {
+ override def addInsert(targetDescriptor: TableDescriptor, table: Table): StreamStatementSet =
super.addInsert(targetDescriptor, table).asInstanceOf[StreamStatementSet]
- }
override def addInsert(
- targetDescriptor: TableDescriptor,
- table: Table,
- overwrite: Boolean)
- : StreamStatementSet = {
+ targetDescriptor: TableDescriptor,
Review comment:
fix indention
##########
File path: flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamStatementSetImpl.scala
##########
@@ -21,40 +21,39 @@ package org.apache.flink.table.api.bridge.scala.internal
import org.apache.flink.annotation.Internal
import org.apache.flink.table.api.bridge.scala.StreamStatementSet
import org.apache.flink.table.api.internal.StatementSetImpl
-import org.apache.flink.table.api.{Table, TableDescriptor}
+import org.apache.flink.table.api.{ExplainDetail, Table, TableDescriptor, TablePipeline}
/** Implementation for [[StreamStatementSet]]. */
@Internal
class StreamStatementSetImpl(tableEnvironment: StreamTableEnvironmentImpl)
extends StatementSetImpl[StreamTableEnvironmentImpl](tableEnvironment)
with StreamStatementSet {
- override def addInsertSql(statement: String): StreamStatementSet = {
+ override def addInsertSql(statement: String): StreamStatementSet =
super.addInsertSql(statement).asInstanceOf[StreamStatementSet]
- }
Review comment:
nit: IMHO we should leave curly braces for methods, we don't need to use very fancy Scala syntax, if you would add another statement, you would add the statement to the class init, pretty dangerous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
}, {
"hash" : "9b35583c42db89538dfce7d11dcf9d16ce672b9b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31645",
"triggerID" : "9b35583c42db89538dfce7d11dcf9d16ce672b9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
* 9b35583c42db89538dfce7d11dcf9d16ce672b9b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31645)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
}, {
"hash" : "9b35583c42db89538dfce7d11dcf9d16ce672b9b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b35583c42db89538dfce7d11dcf9d16ce672b9b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
* 9b35583c42db89538dfce7d11dcf9d16ce672b9b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31534)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18755:
URL: https://github.com/apache/flink/pull/18755#issuecomment-1039066287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416",
"triggerID" : "cbd78cd85cfd9d2791fba1c255cad43fe0857738",
"triggerType" : "PUSH"
}, {
"hash" : "b133c7767bd5e2e453241acf093e24965df4727b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492",
"triggerID" : "b133c7767bd5e2e453241acf093e24965df4727b",
"triggerType" : "PUSH"
}, {
"hash" : "906cbe59a62057b26080a4634044d149a8e5b247",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522",
"triggerID" : "906cbe59a62057b26080a4634044d149a8e5b247",
"triggerType" : "PUSH"
}, {
"hash" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd78cd85cfd9d2791fba1c255cad43fe0857738 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31416)
* b133c7767bd5e2e453241acf093e24965df4727b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31492)
* 906cbe59a62057b26080a4634044d149a8e5b247 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31522)
* bdc5aaa6ecf3b43e5ab4b0d55462361a2b0637f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18755: [FLINK-26089][table-planner] Introduce TablePipeline
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18755:
URL: https://github.com/apache/flink/pull/18755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org