[GitHub] [helix] qqu0127 commented on a diff in pull request #2325: Refactor zookeeper-api module with more flexible watcher and connection setup

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2325:
URL: https://github.com/apache/helix/pull/2325#discussion_r1060694087


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1424,7 +1426,7 @@ public Boolean call() throws Exception {
     } finally {
       long endT = System.currentTimeMillis();
       if (LOG.isTraceEnabled()) {
-        LOG.trace("zkclient exists, path: {}, time: {} ms", _uid, path, (endT - startT));
+        LOG.trace("zkclient {} exists, path: {}, time: {} ms", _uid, path, (endT - startT));

Review Comment:
   I don't think we do, the IDE has some warnings though. And it's not hard failing after all. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org