You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by pk...@apache.org on 2022/06/15 19:06:14 UTC

[incubator-nuttx] branch master updated: xtensa: Remove old references to co-processors.

This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 996995245d xtensa: Remove old references to co-processors.
996995245d is described below

commit 996995245df63f59a5c196594e8764d64661374c
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Wed May 25 12:13:33 2022 +0200

    xtensa: Remove old references to co-processors.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 arch/xtensa/src/common/xtensa_cpupause.c    | 4 ++--
 arch/xtensa/src/common/xtensa_irqdispatch.c | 7 +------
 arch/xtensa/src/common/xtensa_sigdeliver.c  | 1 -
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/arch/xtensa/src/common/xtensa_cpupause.c b/arch/xtensa/src/common/xtensa_cpupause.c
index b6fbead007..1f33cdf5bd 100644
--- a/arch/xtensa/src/common/xtensa_cpupause.c
+++ b/arch/xtensa/src/common/xtensa_cpupause.c
@@ -109,8 +109,8 @@ int up_cpu_paused(int cpu)
   sched_note_cpu_paused(tcb);
 #endif
 
-  /* Copy the CURRENT_REGS into the OLD TCB (otcb).  The co-processor state
-   * will be saved as part of the return from xtensa_irq_dispatch().
+  /* Save the current context at CURRENT_REGS into the TCB at the head
+   * of the assigned task list for this CPU.
    */
 
   xtensa_savestate(tcb->xcp.regs);
diff --git a/arch/xtensa/src/common/xtensa_irqdispatch.c b/arch/xtensa/src/common/xtensa_irqdispatch.c
index 94738344d8..7c5e26b43b 100644
--- a/arch/xtensa/src/common/xtensa_irqdispatch.c
+++ b/arch/xtensa/src/common/xtensa_irqdispatch.c
@@ -62,12 +62,7 @@ uint32_t *xtensa_irq_dispatch(int irq, uint32_t *regs)
 
   CURRENT_REGS = regs;
 
-  /* Deliver the IRQ
-   *
-   * NOTE: Co-process state has not been saved yet (see below).  As a
-   * consequence, no interrupt level logic may perform co-processor
-   * operations.  This includes use of the FPU.
-   */
+  /* Deliver the IRQ */
 
   irq_dispatch(irq, regs);
 
diff --git a/arch/xtensa/src/common/xtensa_sigdeliver.c b/arch/xtensa/src/common/xtensa_sigdeliver.c
index 5aefeb14df..a18e3a281f 100644
--- a/arch/xtensa/src/common/xtensa_sigdeliver.c
+++ b/arch/xtensa/src/common/xtensa_sigdeliver.c
@@ -140,7 +140,6 @@ void xtensa_sig_deliver(void)
   rtcb->xcp.sigdeliver = NULL;  /* Allows next handler to be scheduled */
 
   /* Then restore the correct state for this thread of execution.
-   * NOTE: The co-processor state should already be correct.
    */
 
   board_autoled_off(LED_SIGNAL);