You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by QP Hou <ho...@apache.org> on 2021/08/10 20:47:34 UTC
[VOTE][RUST][Datafusion] Release Apache Arrow Datafusion 5.0.0 RC1
Hi,
I would like to propose a release of Apache Arrow Datafusion Implementation,
version 5.0.0.
This release candidate is based on commit:
96658eb100436c47601ed10095d74299d2229020 [1]
The proposed release tarball and signatures are hosted at [2].
The changelog is located at [3].
Please download, verify checksums and signatures, run the unit tests, and vote
on the release. The vote will be open for at least 72 hours.
[ ] +1 Release this as Apache Arrow Datafusion
[ ] +0
[ ] -1 Do not release this as Apache Arrow Datafusion because...
[1]: https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
[2]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
[3]: https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
Thanks,
QP
Re: [VOTE][RUST][Datafusion] Release Apache Arrow Datafusion 5.0.0 RC1
Posted by Andrew Lamb <al...@influxdata.com>.
+1 (binding)
I did the following
1. downloaded the tarball and ran `cargo test --all` on mac OS (x86_64)
2. Verified the versions in Cargo.toml files for datafusion, ballista and
python crates (some of the unpublished crates like datafusion-cli still say
4.0.0-SNAPSHOT)
3. Verified the shasum using the commands below
4. Verified the signatures using the commands below (not sure if the
WARNING is something we should fix)
This release is pretty amazing (the changelogs are pages and pages long!)
Thank you for all the work you have put into this QP,
Andrew
shasum verification:
(arrow_dev) alamb@MacBook-Pro:~/Downloads$ shasum -c
apache-arrow-datafusion-5.0.0.tar.gz.sha256
apache-arrow-datafusion-5.0.0.tar.gz: OK
(arrow_dev) alamb@MacBook-Pro:~/Downloads$ shasum -c
apache-arrow-datafusion-5.0.0.tar.gz.sha512
apache-arrow-datafusion-5.0.0.tar.gz: OK
GPG signature verification:
(arrow_dev) alamb@MacBook-Pro:~/Downloads$ gpg --verify
apache-arrow-datafusion-5.0.0.tar.gz.asc
apache-arrow-datafusion-5.0.0.tar.gz
gpg: Signature made Tue Aug 10 16:34:25 2021 EDT
gpg: using RSA key DF7BAD6652219D7502C87A11CA1AB41406F9DBAD
gpg: Good signature from "Qingping Hou (CODE SIGNING KEY) <ho...@apache.org>"
[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: DF7B AD66 5221 9D75 02C8 7A11 CA1A B414 06F9 DBAD
On Tue, Aug 10, 2021 at 4:48 PM QP Hou <ho...@apache.org> wrote:
> Hi,
>
> I would like to propose a release of Apache Arrow Datafusion
> Implementation,
> version 5.0.0.
>
> This release candidate is based on commit:
> 96658eb100436c47601ed10095d74299d2229020 [1]
> The proposed release tarball and signatures are hosted at [2].
> The changelog is located at [3].
>
> Please download, verify checksums and signatures, run the unit tests, and
> vote
> on the release. The vote will be open for at least 72 hours.
>
> [ ] +1 Release this as Apache Arrow Datafusion
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow Datafusion because...
>
> [1]:
> https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
> [2]:
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
> [3]:
> https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
>
> Thanks,
> QP
>
Re: [VOTE][RUST][Datafusion] Release Apache Arrow Datafusion 5.0.0 RC1
Posted by QP Hou <qp...@scribd.com.INVALID>.
> 4. Verified the signatures using the commands below (not sure if the
WARNING is something we should fix)
I believe the warning is caused by my key not being signed by others
in the network, I will get that fixed.
Thank you Andy for the quick fix, I will send a voting thread for rc2
later tonight. Will also add `cargo publish --dry-run` into the
release test automation script.
Thanks,
QP Hou
On Tue, Aug 10, 2021 at 4:13 PM Andy Grove <an...@gmail.com> wrote:
>
> Here is a PR to resolve this
>
> https://github.com/apache/arrow-datafusion/pull/852
>
>
> On Tue, Aug 10, 2021 at 4:24 PM Andy Grove <an...@gmail.com> wrote:
>
> > Hi QP,
> >
> > This looks great overall but I did run into one issue. The Ballista crates
> > have relative paths for dependencies rather than depending on versioned
> > crates, so we would not be able to publish them to crates.io
> >
> > *$ find ballista -name Cargo.toml -exec grep -H "path" {} \;*
> > ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
> > ballista/rust/scheduler/Cargo.toml:datafusion = { path =
> > "../../../datafusion" }
> > ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
> > ballista/rust/executor/Cargo.toml:ballista-core = { path = "../core" }
> > ballista/rust/executor/Cargo.toml:datafusion = { path =
> > "../../../datafusion" }
> > ballista/rust/core/Cargo.toml:datafusion = { path = "../../../datafusion" }
> > ballista/rust/client/Cargo.toml:ballista-core = { path = "../core" }
> > ballista/rust/client/Cargo.toml:ballista-executor = { path =
> > "../executor", optional = true }
> > ballista/rust/client/Cargo.toml:ballista-scheduler = { path =
> > "../scheduler", optional = true }
> > ballista/rust/client/Cargo.toml:datafusion = { path =
> > "../../../datafusion" }
> >
> > I assume this is relatively simple to fix. I can look into this more later
> > today.
> >
> > Thanks,
> >
> > Andy.
> >
> > On Tue, Aug 10, 2021 at 2:48 PM QP Hou <ho...@apache.org> wrote:
> >
> >> Hi,
> >>
> >> I would like to propose a release of Apache Arrow Datafusion
> >> Implementation,
> >> version 5.0.0.
> >>
> >> This release candidate is based on commit:
> >> 96658eb100436c47601ed10095d74299d2229020 [1]
> >> The proposed release tarball and signatures are hosted at [2].
> >> The changelog is located at [3].
> >>
> >> Please download, verify checksums and signatures, run the unit tests, and
> >> vote
> >> on the release. The vote will be open for at least 72 hours.
> >>
> >> [ ] +1 Release this as Apache Arrow Datafusion
> >> [ ] +0
> >> [ ] -1 Do not release this as Apache Arrow Datafusion because...
> >>
> >> [1]:
> >> https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
> >> [2]:
> >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
> >> [3]:
> >> https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
> >>
> >> Thanks,
> >> QP
> >>
> >
Re: [VOTE][RUST][Datafusion] Release Apache Arrow Datafusion 5.0.0 RC1
Posted by Andy Grove <an...@gmail.com>.
Here is a PR to resolve this
https://github.com/apache/arrow-datafusion/pull/852
On Tue, Aug 10, 2021 at 4:24 PM Andy Grove <an...@gmail.com> wrote:
> Hi QP,
>
> This looks great overall but I did run into one issue. The Ballista crates
> have relative paths for dependencies rather than depending on versioned
> crates, so we would not be able to publish them to crates.io
>
> *$ find ballista -name Cargo.toml -exec grep -H "path" {} \;*
> ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
> ballista/rust/scheduler/Cargo.toml:datafusion = { path =
> "../../../datafusion" }
> ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
> ballista/rust/executor/Cargo.toml:ballista-core = { path = "../core" }
> ballista/rust/executor/Cargo.toml:datafusion = { path =
> "../../../datafusion" }
> ballista/rust/core/Cargo.toml:datafusion = { path = "../../../datafusion" }
> ballista/rust/client/Cargo.toml:ballista-core = { path = "../core" }
> ballista/rust/client/Cargo.toml:ballista-executor = { path =
> "../executor", optional = true }
> ballista/rust/client/Cargo.toml:ballista-scheduler = { path =
> "../scheduler", optional = true }
> ballista/rust/client/Cargo.toml:datafusion = { path =
> "../../../datafusion" }
>
> I assume this is relatively simple to fix. I can look into this more later
> today.
>
> Thanks,
>
> Andy.
>
> On Tue, Aug 10, 2021 at 2:48 PM QP Hou <ho...@apache.org> wrote:
>
>> Hi,
>>
>> I would like to propose a release of Apache Arrow Datafusion
>> Implementation,
>> version 5.0.0.
>>
>> This release candidate is based on commit:
>> 96658eb100436c47601ed10095d74299d2229020 [1]
>> The proposed release tarball and signatures are hosted at [2].
>> The changelog is located at [3].
>>
>> Please download, verify checksums and signatures, run the unit tests, and
>> vote
>> on the release. The vote will be open for at least 72 hours.
>>
>> [ ] +1 Release this as Apache Arrow Datafusion
>> [ ] +0
>> [ ] -1 Do not release this as Apache Arrow Datafusion because...
>>
>> [1]:
>> https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
>> [2]:
>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
>> [3]:
>> https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
>>
>> Thanks,
>> QP
>>
>
Re: [VOTE][RUST][Datafusion] Release Apache Arrow Datafusion 5.0.0 RC1
Posted by Andy Grove <an...@gmail.com>.
Hi QP,
This looks great overall but I did run into one issue. The Ballista crates
have relative paths for dependencies rather than depending on versioned
crates, so we would not be able to publish them to crates.io
*$ find ballista -name Cargo.toml -exec grep -H "path" {} \;*
ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/scheduler/Cargo.toml:datafusion = { path =
"../../../datafusion" }
ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/executor/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/executor/Cargo.toml:datafusion = { path =
"../../../datafusion" }
ballista/rust/core/Cargo.toml:datafusion = { path = "../../../datafusion" }
ballista/rust/client/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/client/Cargo.toml:ballista-executor = { path = "../executor",
optional = true }
ballista/rust/client/Cargo.toml:ballista-scheduler = { path =
"../scheduler", optional = true }
ballista/rust/client/Cargo.toml:datafusion = { path = "../../../datafusion"
}
I assume this is relatively simple to fix. I can look into this more later
today.
Thanks,
Andy.
On Tue, Aug 10, 2021 at 2:48 PM QP Hou <ho...@apache.org> wrote:
> Hi,
>
> I would like to propose a release of Apache Arrow Datafusion
> Implementation,
> version 5.0.0.
>
> This release candidate is based on commit:
> 96658eb100436c47601ed10095d74299d2229020 [1]
> The proposed release tarball and signatures are hosted at [2].
> The changelog is located at [3].
>
> Please download, verify checksums and signatures, run the unit tests, and
> vote
> on the release. The vote will be open for at least 72 hours.
>
> [ ] +1 Release this as Apache Arrow Datafusion
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow Datafusion because...
>
> [1]:
> https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
> [2]:
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
> [3]:
> https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
>
> Thanks,
> QP
>