You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mohanraj Loganathan (JIRA)" <ji...@apache.org> on 2010/08/13 11:12:17 UTC

[jira] Created: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

[classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
--------------------------------------------------------------------------------------------------------

                 Key: HARMONY-6623
                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
             Project: Harmony
          Issue Type: Bug
          Components: Non-bug differences from RI
         Environment: Windows/Linux
            Reporter: Mohanraj Loganathan


Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  

This is the same case with defl.setStrategy() function also.

[1] public void test () {
       byte[] byteArray = new byte[100];
       InputStream inFile = new FileInputStream(new File("Input.txt"));
                      //input.txt - any text file with some text in it.
       inFile.read(byteArray);
       inFile.close();
       Deflater defl = new Deflater();
       byte[] outPutBuf = new byte[500];
       defl.setInput(byteArray);
       defl.setLevel(2);
       while (!defl.needsInput()) {
           defl.deflate(outPutBuf);
       }
       defl.finish();
       while (!defl.finished()) {
           defl.deflate(outPutBuf);
       }

       int totalOut;
       totalOut = defl.getTotalOut();
       System.out.println("TotalOut=" + totalOut);
}



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903830#action_12903830 ] 

Hudson commented on HARMONY-6623:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #940 (See [https://hudson.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/940/])
    Apply patch for HARMONY-6623 ([classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null)


> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>            Assignee: Oliver Deakin
>             Fix For: 6.0M3, 5.0M15
>
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Mohanraj Loganathan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohanraj Loganathan closed HARMONY-6623.
----------------------------------------


Thanks Oliver. I verified @ r989795. Patches are applied as expected. 

> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>            Assignee: Oliver Deakin
>             Fix For: 6.0M3, 5.0M15
>
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Mohanraj Loganathan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohanraj Loganathan updated HARMONY-6623:
-----------------------------------------

    Attachment: HARMONY-6623.patch

Patch HARMONY-6623.patch taken from Java5 level. 
It can be applied to Java6 level also.

All the unit tests from Archive passes after this change.  I believe checking inputBuffer!=NULL not required while setLevel and setStrategy. 





> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902987#action_12902987 ] 

Hudson commented on HARMONY-6623:
---------------------------------

Integrated in Harmony-select-1.5-head-linux-x86_64 #102 (See [https://hudson.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/102/])
    Apply patch for HARMONY-6623 ([classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null)


> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>            Assignee: Oliver Deakin
>             Fix For: 6.0M3, 5.0M15
>
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin reassigned HARMONY-6623:
--------------------------------------

    Assignee: Oliver Deakin

> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>            Assignee: Oliver Deakin
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6623) [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin resolved HARMONY-6623.
------------------------------------

    Fix Version/s: 6.0M3
                   5.0M15
       Resolution: Fixed

Thanks Mohan. Patch applied at repo revision r989780. Please check it applied as expected.

> [classlib][archive]Deflater.setlevel/setStrategy throws IllegalStateException if inputBuffer is not null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6623
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6623
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>         Environment: Windows/Linux
>            Reporter: Mohanraj Loganathan
>            Assignee: Oliver Deakin
>             Fix For: 6.0M3, 5.0M15
>
>         Attachments: HARMONY-6623.patch
>
>
> Please consider the below testcase [1] . RI works fine. But Harmony throws IllegalStateException.  
> This is the same case with defl.setStrategy() function also.
> [1] public void test () {
>        byte[] byteArray = new byte[100];
>        InputStream inFile = new FileInputStream(new File("Input.txt"));
>                       //input.txt - any text file with some text in it.
>        inFile.read(byteArray);
>        inFile.close();
>        Deflater defl = new Deflater();
>        byte[] outPutBuf = new byte[500];
>        defl.setInput(byteArray);
>        defl.setLevel(2);
>        while (!defl.needsInput()) {
>            defl.deflate(outPutBuf);
>        }
>        defl.finish();
>        while (!defl.finished()) {
>            defl.deflate(outPutBuf);
>        }
>        int totalOut;
>        totalOut = defl.getTotalOut();
>        System.out.println("TotalOut=" + totalOut);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.