You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Dawid Weiss <da...@cs.put.poznan.pl> on 2012/06/12 20:20:59 UTC
Re: Typo in test framework
Hi Shai.
I think this question may be of relevance to others, so I allowed
myself to CC the list. So:
> I see these printed when I run test-core:
>
> [junit4] IGNOR/A 0.00s | Test10KPulsings.test10kNotPulsed
> [junit4] > Assumption #1: 'nightly' test group is disabled (@Nightly)
>
> Is IGNOR a typo? Or is it a weird locale?
JUnit has the notion of "ignored" test (marked with @Ignore) or
"assumption-ignored" test which is physically executed but at some
point ends with an AssumptionViolatedException:
https://github.com/KentBeck/junit/blob/master/src/main/java/org/junit/internal/AssumptionViolatedException.java
The primary distinction is that the test can evaluate a condition and
decide to throw an assumption while @Ignore is unconditional. There
are also other technical side-effects -- listeners do get informed
about the cause of an assumption (an instance of the thrown exception)
while they are not informed about any cause of the ignored test (I
think because it was at some point assumed that tests can only be
ignored for one reason -- @Ignore annotation). Assumption-ignore
exceptions can happen simultaneously with other exceptions resulting
from rules -- the behavior then is not clearly defined...
Randomizedtesting's <junit4> task tries hard to report all the events
that really happened and report them -- including assumption-failed
tests. So IGNOR/A is an assumption-ignored test (as opposed to IGNORED
which is a test ignored for other reasons).
Hope this helps,
Dawid
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Typo in test framework
Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
> I guess if it just spelled IGNORED/A, I wouldn't think it's a typo. If it's
> possible, can we have it spelled correctly? It's not critical if it's too
Hmm... It makes that column two characters wider! :)
D.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Typo in test framework
Posted by Shai Erera <se...@gmail.com>.
Thanks Dawid,
I guess if it just spelled IGNORED/A, I wouldn't think it's a typo. If it's
possible, can we have it spelled correctly? It's not critical if it's too
much work.
Shai
On Tue, Jun 12, 2012 at 9:20 PM, Dawid Weiss
<da...@cs.put.poznan.pl>wrote:
> Hi Shai.
>
> I think this question may be of relevance to others, so I allowed
> myself to CC the list. So:
>
> > I see these printed when I run test-core:
> >
> > [junit4] IGNOR/A 0.00s | Test10KPulsings.test10kNotPulsed
> > [junit4] > Assumption #1: 'nightly' test group is disabled (@Nightly)
> >
> > Is IGNOR a typo? Or is it a weird locale?
>
> JUnit has the notion of "ignored" test (marked with @Ignore) or
> "assumption-ignored" test which is physically executed but at some
> point ends with an AssumptionViolatedException:
>
>
> https://github.com/KentBeck/junit/blob/master/src/main/java/org/junit/internal/AssumptionViolatedException.java
>
> The primary distinction is that the test can evaluate a condition and
> decide to throw an assumption while @Ignore is unconditional. There
> are also other technical side-effects -- listeners do get informed
> about the cause of an assumption (an instance of the thrown exception)
> while they are not informed about any cause of the ignored test (I
> think because it was at some point assumed that tests can only be
> ignored for one reason -- @Ignore annotation). Assumption-ignore
> exceptions can happen simultaneously with other exceptions resulting
> from rules -- the behavior then is not clearly defined...
>
> Randomizedtesting's <junit4> task tries hard to report all the events
> that really happened and report them -- including assumption-failed
> tests. So IGNOR/A is an assumption-ignored test (as opposed to IGNORED
> which is a test ignored for other reasons).
>
> Hope this helps,
>
> Dawid
>