[jira] Commented: (WICKET-2235) Image tags using full paths are broken when wrapped in an a tag that uses wicket:link

["Mike Comb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703431#action_12703431 ] 

Mike Comb commented on WICKET-2235:
-----------------------------------

This isn't a feature request, it's a bug.  This worked fine through 1.4m3 and we built websites around the way it used to work.  In 1.4rc1 a bug was introduced that broke previously working functionality.  Going back through our existing websites and updating them to make every link a component is not an option.  I'd be glad to submit a patch that reverts this functionality to the way in was in 1.4m3 if that would help.

> Image tags using full paths are broken when wrapped in an a tag that uses wicket:link
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-2235
>                 URL: https://issues.apache.org/jira/browse/WICKET-2235
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Safari  on OS X, probably others
>            Reporter: Mike Comb
>            Assignee: Igor Vaynberg
>
> HTML that looks like this:
> <wicket:link><a href="SomePage.html"><img src="/some/full/path/image.gif" /></a></wicket:link>
> Will get converted to this:
> <wicket:link><a href="../SomePage"><img onclick="window.location.href='/some/full/path/image.gif';return false;" src="/some/full/path/image.gif"/></a></wicket:link>
> The onclick that gets added to the image is unnecessary and results in the browser directing to the image rather than the intended target page when the image is clicked on.  This behavior is still present in trunk as of 4/22/09.  A temporary workaround is to comment out the offending line in ExternalLink.java that is adding the onclick event.  It's unclear to me what the purpose of that event is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.