[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8214: [E2E]Fix file manage e2e error

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #8214:
URL: https://github.com/apache/dolphinscheduler/pull/8214#discussion_r793249477



##########
File path: dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/FileManageE2ETest.java
##########
@@ -289,7 +290,7 @@ void testUploadUnder1GBFile() throws IOException {
 
         page.uploadFile(testUnder1GBFilePath.toFile().getAbsolutePath());
 
-        await().untilAsserted(() -> {
+        await().pollDelay(Duration.ofSeconds(2)).untilAsserted(() -> {
             assertThat(page.fileList())
                 .as("File list should contain newly-created file")
                 .extracting(WebElement::getText)

Review comment:
       I don't think this resolves the problem, `pollDelay` only add some delay before the assertion, but this assertion will be retried for some times if it failed, if adding delay resolves the problem, retrying should also do the trick.
   
   I think you should add a refresh inside the assertion, like
   
   ```suggestion
           await().untilAsserted(() -> {
               browser.navigate().refresh();
               assertThat(page.fileList())
                   .as("File list should contain newly-created file")
                   .extracting(WebElement::getText)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org