You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "steveloughran (via GitHub)" <gi...@apache.org> on 2026/05/19 12:12:51 UTC
[PR] GH-112 Harden variant decoding [parquet-testing]
steveloughran opened a new pull request, #113:
URL: https://github.com/apache/parquet-testing/pull/113
Add parquet files with malformed variant data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on code in PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#discussion_r3677434594
##########
bad_data/README.md:
##########
@@ -35,3 +35,31 @@ These are files used for reproducing various bugs that have been reported.
where repetition levels start with a 1 instead of 0.
* ARROW-GH-47662.parquet: test case identified in https://github.com/apache/arrow/issues/47662
where a required column contains null values (an incorrect version of data/fixed_length_byte_array.parquet).
+
+
+## Directory `variants`
+
+This subdirectory contains files with malformed variant structures.
+
+Robust implementations of variant decoders SHOULD reject these.
+
+| File | Malformed Structure |
+|---------------------------------------------------------------|----------------------------------------------------------------------------|
Review Comment:
until the relevant PR is merged, that code doesn't really exist, does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on code in PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#discussion_r3677666685
##########
bad_data/README.md:
##########
@@ -35,3 +35,31 @@ These are files used for reproducing various bugs that have been reported.
where repetition levels start with a 1 instead of 0.
* ARROW-GH-47662.parquet: test case identified in https://github.com/apache/arrow/issues/47662
where a required column contains null values (an incorrect version of data/fixed_length_byte_array.parquet).
+
+
+## Directory `variants`
+
+This subdirectory contains files with malformed variant structures.
+
+Robust implementations of variant decoders SHOULD reject these.
+
+| File | Malformed Structure |
+|---------------------------------------------------------------|----------------------------------------------------------------------------|
Review Comment:
Agreed but those are in the tests of the Java repo. The data/README here has a snippet of the code that was used to generate the files. I'd prefer that be here rather than link to another repo. I'm okay reusing the same code but having it here is better for users to reproduce the artifacts. If you are planning to do that after the code merges, that's great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #113:
URL: https://github.com/apache/parquet-testing/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#issuecomment-5269743696
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#discussion_r3711341615
##########
bad_data/README.md:
##########
@@ -35,3 +35,31 @@ These are files used for reproducing various bugs that have been reported.
where repetition levels start with a 1 instead of 0.
* ARROW-GH-47662.parquet: test case identified in https://github.com/apache/arrow/issues/47662
where a required column contains null values (an incorrect version of data/fixed_length_byte_array.parquet).
+
+
+## Directory `variants`
+
+This subdirectory contains files with malformed variant structures.
+
+Robust implementations of variant decoders SHOULD reject these.
+
+| File | Malformed Structure |
+|---------------------------------------------------------------|----------------------------------------------------------------------------|
Review Comment:
I think it is ok not to include reproducer of malformed data -- a link to the relevant PR (or perhaps a gist) would be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on code in PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#discussion_r3670864166
##########
bad_data/README.md:
##########
@@ -35,3 +35,31 @@ These are files used for reproducing various bugs that have been reported.
where repetition levels start with a 1 instead of 0.
* ARROW-GH-47662.parquet: test case identified in https://github.com/apache/arrow/issues/47662
where a required column contains null values (an incorrect version of data/fixed_length_byte_array.parquet).
+
+
+## Directory `variants`
+
+This subdirectory contains files with malformed variant structures.
+
+Robust implementations of variant decoders SHOULD reject these.
+
+| File | Malformed Structure |
+|---------------------------------------------------------------|----------------------------------------------------------------------------|
Review Comment:
Would be great to add the sample code that helped generate these individual cases in the README as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-112 Harden variant decoding: example data [parquet-testing]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#issuecomment-5265127958
Thanks @alamb...can someone with merge permissions merge this? The cross-project pr ref can go in the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org