You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/09/19 09:07:23 UTC
[GitHub] spark pull request #22464: Revert [SPARK-19355][SPARK-25352]
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22464
Revert [SPARK-19355][SPARK-25352]
## What changes were proposed in this pull request?
This goes to revert [SPARK-19355](https://github.com/apache/spark/pull/16677) and [SPARK-25352](https://github.com/apache/spark/pull/22344).
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 revert-SPARK-19355
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22464
----
commit 8ee721c2923ba125e8d00610a7d9d489010022de
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-09-19T09:02:31Z
Revert SPARK-19355 and SPARK-25352.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22464: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/22464
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22464
**[Test build #96240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96240/testReport)** for PR 22464 at commit [`8ee721c`](https://github.com/apache/spark/commit/8ee721c2923ba125e8d00610a7d9d489010022de).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22464
just one PR including 4 commits
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
@cloud-fan Shall we have 4 PRs to revert these PRs individually?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22464
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22464
I just put the link here: https://github.com/apache/spark/pull/16677#issuecomment-422650759
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22464
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3232/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22464
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96240/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22464
**[Test build #96240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96240/testReport)** for PR 22464 at commit [`8ee721c`](https://github.com/apache/spark/commit/8ee721c2923ba125e8d00610a7d9d489010022de).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait BaseLimitExec extends UnaryExecNode with CodegenSupport `
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
cc @cloud-fan @rxin @hvanhovell
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
Thanks @HyukjinKwon @maropu. I've put it in the PR description.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22464
@viirya Thanks for doing it! To ease the review, can you revert these 4 commits sequentially with `git revert commit-hash`? Thanks!
https://github.com/apache/spark/pull/22344
https://github.com/apache/spark/pull/22330
https://github.com/apache/spark/pull/22239
https://github.com/apache/spark/pull/16677
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22464
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22464
@viirya, not a big deal but mind leaving few explicit discussion links (in the PRs you pointed out) to the current PR description?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22464
@cloud-fan Ok. Let me try it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org