[jira] [Commented] (OFBIZ-5363) Add Support For Tomcat JDBC Connection Pool

["Adam Heath (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043669#comment-14043669 ] 

Adam Heath commented on OFBIZ-5363:
-----------------------------------

That patch is interesting, but does more than it sets out to do.  It should *only* add support for this new pool impl; for instance, it moves the "select" string into a static constant on the interface.

Additionally, there is an ordering issue in the build. the entity/build/.xml references catalina/lib, which comes after it.

Also, the linked page menitions that dbcp 1.x is poor, that 2.x is better, but that tomcat jdbc pool is better.  It doesn't say if it is better than 1.x, or 2.x, or how 2.x is different, really.  And, since ofbiz uses 1.x, why can't we also compare that new version?

> Add Support For Tomcat JDBC Connection Pool
> -------------------------------------------
>
>                 Key: OFBIZ-5363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5363
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adam Heath
>            Priority: Minor
>         Attachments: OFBIZ-5363.patch, tomcat-7.0.42-tomcat-jdbc.jar
>
>
> According to Tomcat, their JDBC connection pool is a better implementation than DBCP (http://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html). This issue adds the Tomcat JDBC Connection Pool as an option.



--
This message was sent by Atlassian JIRA
(v6.2#6252)