You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/12 10:43:17 UTC
[PR] update build [incubator-pekko-projection]
pjfanning opened a new pull request, #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107
* scala 2.13.12
* don't hardcode full scala versions in CI yml (easier maintenance)
* use more sbt-pekko-build style dependency management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486021281
##########
slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:
##########
@@ -198,7 +198,7 @@ private[projection] class SlickProjectionImpl[Offset, Envelope, P <: JdbcProfile
databaseConfig.db.run(offsetStore.saveOffset(projectionId, offset)).map(_ => Done)
private[projection] def newRunningInstance(): RunningProjection =
- new SlickRunningProjection(RunningProjection.withBackoff(() => mappedSource(), settings), this)
+ new SlickRunningProjection(RunningProjection.withBackoff(() => this.mappedSource(), settings), this)
Review Comment:
Whats reason behind this change, some deprecation warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486029521
##########
project/PekkoSnapshotRepository.scala:
##########
@@ -19,11 +19,6 @@ object PekkoSnapshotRepositories extends AutoPlugin {
// If using a snapshot version of either Pekko or Pekko Connectors, add both snapshot repos
// in case there are transitive dependencies to other snapshot artifacts
override def projectSettings: Seq[Def.Setting[_]] = {
- resolvers ++= (sys.props
- .get("build.pekko.version")
- .orElse(sys.props.get("build.connectors.kafka.version")) match {
- case Some(_) => Seq(Resolver.ApacheMavenSnapshotsRepo)
- case None => Seq.empty
- })
+ resolvers += Resolver.ApacheMavenSnapshotsRepo
Review Comment:
Maybe also update(/remove?) the comment above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486100155
##########
project/PekkoSnapshotRepository.scala:
##########
@@ -19,11 +19,6 @@ object PekkoSnapshotRepositories extends AutoPlugin {
// If using a snapshot version of either Pekko or Pekko Connectors, add both snapshot repos
// in case there are transitive dependencies to other snapshot artifacts
override def projectSettings: Seq[Def.Setting[_]] = {
- resolvers ++= (sys.props
- .get("build.pekko.version")
- .orElse(sys.props.get("build.connectors.kafka.version")) match {
- case Some(_) => Seq(Resolver.ApacheMavenSnapshotsRepo)
- case None => Seq.empty
- })
+ resolvers += Resolver.ApacheMavenSnapshotsRepo
Review Comment:
I've changed this with https://github.com/apache/incubator-pekko-projection/pull/107/commits/59f2d1c569f2eca8dd9d2d4b7199fe93fdf3a91f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486024395
##########
slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:
##########
@@ -198,7 +198,7 @@ private[projection] class SlickProjectionImpl[Offset, Envelope, P <: JdbcProfile
databaseConfig.db.run(offsetStore.saveOffset(projectionId, offset)).map(_ => Done)
private[projection] def newRunningInstance(): RunningProjection =
- new SlickRunningProjection(RunningProjection.withBackoff(() => mappedSource(), settings), this)
+ new SlickRunningProjection(RunningProjection.withBackoff(() => this.mappedSource(), settings), this)
Review Comment:
build issue after updating to scala 2.13.12
```
[error] /home/runner/work/incubator-pekko-projection/incubator-pekko-projection/slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:201:70: reference to mappedSource is ambiguous;
[error] it is both defined in the enclosing class SlickProjectionImpl and inherited in the enclosing class SlickInternalProjectionState as method mappedSource (defined in class InternalProjectionState)
[error] In Scala 2, symbols inherited from a superclass shadow symbols defined in an outer scope.
[error] Such references are ambiguous in Scala 3. To continue using the inherited symbol, write `this.mappedSource`.
[error] Or use `-Wconf:msg=legacy-binding:s` to silence this warning. [quickfixable]
[error] new SlickRunningProjection(RunningProjection.withBackoff(() => mappedSource(), settings), this)
[error] ^
[error] one error found
[error] (slick / Compile / compileIncremental) Compilation failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] update build [incubator-pekko-projection]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #107:
URL: https://github.com/apache/incubator-pekko-projection/pull/107#discussion_r1486122423
##########
build.sbt:
##########
@@ -15,6 +15,8 @@ sourceDistName := "apache-pekko-projection"
sourceDistIncubating := true
ThisBuild / pekkoInlineEnabled := false
+// we want to be able to test with snapshot versions of Pekko dependencies
+ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo
Review Comment:
it was nice that this used to be conditional, but not a big issue to have it here I suppose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org