You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "Will-Lo (via GitHub)" <gi...@apache.org> on 2023/04/08 01:32:58 UTC
[GitHub] [gobblin] Will-Lo opened a new pull request, #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Will-Lo opened a new pull request, #3669:
URL: https://github.com/apache/gobblin/pull/3669
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1808
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
TODO: Update documentation/dist folders to have the right version of Guava
Currently the version of Guava, 15.0, is from 2013, we want to introduce a newer version of Guava that should hopefully not cause as many issues with other dependencies, such as Guava 20.0 (2016).
This is the start of many version upgrades Gobblin will need to modernize and stay compatible with recent dependencies (e.g. GRPC)
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Passes unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] phet commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "phet (via GitHub)" <gi...@apache.org>.
phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1161890560
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
did I miss it? I would have expected to see a new/adjusted import in this PR to bring in (e.g. annotations) from this new package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] phet commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "phet (via GitHub)" <gi...@apache.org>.
phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1163062159
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
I saw that, but wouldn't there also be a new `import` in java code? ...or are classes already imported under a package that stays fixed, but the package now comes from a separate jar than it used to?
overall, I'm still unclear (from reading only the code under PR) why this dep is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#issuecomment-1500759912
## [Codecov](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3669](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004fef9) into [master](https://codecov.io/gh/apache/gobblin/commit/0d69363abc776812a4f0352860a4125c7f28a508?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d69363) will **increase** coverage by `1.63%`.
> The diff coverage is `28.57%`.
```diff
@@ Coverage Diff @@
## master #3669 +/- ##
============================================
+ Coverage 46.84% 48.47% +1.63%
+ Complexity 10751 7899 -2852
============================================
Files 2139 1479 -660
Lines 84032 58424 -25608
Branches 9335 6712 -2623
============================================
- Hits 39366 28322 -11044
+ Misses 41082 27476 -13606
+ Partials 3584 2626 -958
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...management/partition/CopyableDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BhcnRpdGlvbi9Db3B5YWJsZURhdGFzZXRSZXF1ZXN0b3IuamF2YQ==) | `35.48% <0.00%> (ø)` | |
| [.../org/apache/gobblin/hive/HiveRegistrationUnit.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdpc3RyYXRpb25Vbml0LmphdmE=) | `55.49% <0.00%> (-3.47%)` | :arrow_down: |
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `17.89% <0.00%> (ø)` | |
| [...ocation/PriorityIterableBasedRequestAllocator.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvcmVxdWVzdF9hbGxvY2F0aW9uL1ByaW9yaXR5SXRlcmFibGVCYXNlZFJlcXVlc3RBbGxvY2F0b3IuamF2YQ==) | `68.42% <0.00%> (ø)` | |
| [...gobblin/data/management/copy/hive/HiveDataset.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlRGF0YXNldC5qYXZh) | `84.03% <50.00%> (ø)` | |
| [.../management/source/LoopingDatasetFinderSource.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3NvdXJjZS9Mb29waW5nRGF0YXNldEZpbmRlclNvdXJjZS5qYXZh) | `81.98% <50.00%> (ø)` | |
| [...nt/copy/writer/FileAwareInputStreamDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd3JpdGVyL0ZpbGVBd2FyZUlucHV0U3RyZWFtRGF0YVdyaXRlci5qYXZh) | `72.76% <100.00%> (ø)` | |
... and [665 files with indirect coverage changes](https://codecov.io/gh/apache/gobblin/pull/3669/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "arjun4084346 (via GitHub)" <gi...@apache.org>.
arjun4084346 commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1163427541
##########
gobblin-modules/gobblin-elasticsearch-deps/build.gradle:
##########
@@ -33,7 +33,7 @@ tasks.remove(tasks.uploadShadow)
dependencies {
compile "org.elasticsearch.client:transport:5.6.8"
compile "org.elasticsearch.client:elasticsearch-rest-high-level-client:5.6.8"
- compile "com.google.guava:guava:18.0"
+ compile "com.google.guava:guava:20.0"
Review Comment:
why does this module define complete coordinate of dependency here, why not ```compile externalDependency guava```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] phet commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "phet (via GitHub)" <gi...@apache.org>.
phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1164446591
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
yes, I see... makes sense there would be no `import`s needed in the case of one of our direct deps having left out their own dependency so it falls instead upon us to specify for them. clearly preferable when transitive dependency resolution automates the solution... but now that we know what's missing, not too hard for us to add manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1162034720
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
Only needed it in `gobblin-utility/build.gradle`, not sure if I should've added it to every build.gradle module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1162034720
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
Only needed it in `gobblin-utility/build.gradle`, not sure if I should've added it to every build.gradle class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1164426604
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
Errorprone is needed for some annotations such as `@IgnoreReturnValue` which is used in Guava transitively, but they removed the direct dependency on it so we have to include it manually.
It's discussed in this Github thread where the fix is to include errorProne as a compile dependency, otherwise we will have to bump to a future version of Guava https://github.com/google/guava/issues/2837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3669: [GOBBLIN-1808] Bump Guava version from 15.0 to 20.0
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3669:
URL: https://github.com/apache/gobblin/pull/3669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org