You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/28 20:11:56 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25148:
[SPARK-28326][SQL][TEST] Port join.sql
dongjoon-hyun commented on a change in pull request #25148: [SPARK-28326][SQL][TEST] Port join.sql
URL: https://github.com/apache/spark/pull/25148#discussion_r308016183
##########
File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/join.sql
##########
@@ -0,0 +1,2079 @@
+--
+-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
+--
+--
+-- JOIN
+-- Test JOIN clauses
+-- https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/join.sql
+--
+create or replace temporary view INT4_TBL as select * from
Review comment:
Shall we use `upper case` like `CREATE OR ...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org