[GitHub] [incubator-doris] morningman commented on a diff in pull request #9418: [Bug] Missing error tablet list when close_wait return error

[GitBox <gi...@apache.org>]

morningman commented on code in PR #9418:
URL: https://github.com/apache/incubator-doris/pull/9418#discussion_r867288661


##########
be/src/olap/delta_writer.cpp:
##########
@@ -321,7 +322,13 @@ Status DeltaWriter::close_wait(google::protobuf::RepeatedPtrField<PTabletInfo>*
     }
 
     // return error if previous flush failed
-    RETURN_NOT_OK(_flush_token->wait());
+    Status s = Status::OK();

Review Comment:
   ```suggestion
       Status s = _flush_token->wait();
       if (!s.ok()) {
       ...
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org