[tomcat] branch main updated: Expand comments in build.release.properties

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 800efa449a Expand comments in build.release.properties
800efa449a is described below

commit 800efa449aaedd4e8a76efc8c2fd492974582044
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Jun 9 14:26:48 2022 +0100

    Expand comments in build.release.properties
    
    Also clarify which information is a property being set for consumption
    by the build script.
---
 build.xml | 35 ++++++++++++++++++++++++-----------
 1 file changed, 24 insertions(+), 11 deletions(-)

diff --git a/build.xml b/build.xml
index 69a373b162..92c0c5fd53 100644
--- a/build.xml
+++ b/build.xml
@@ -2664,19 +2664,32 @@ skip.installer property in build.properties" />
 # limitations under the License.
 # -----------------------------------------------------------------------------
 
-# These ant.tstamp properties specify the build-timestamp for repeatable builds.
-ant.tstamp.now.iso=${tstamp.iso.release}
-# This is the ASF user who is the Release Manager for this release.
-release.asfusername=${release.asfusername}
+# This file was auto-generated by the pre-release Ant target
+
 # Set the version-suffix to "" (empty string) as this is not a development release.
 version.suffix=
-# Release build environment information:
-release.java.version=${java.version}
-release.java.vm.name=${java.vm.name}
-release.java.vm.version=${java.vm.version}
-release.os=${os.arch} ${os.name} ${os.version}
-release.default.file.encoding=${file.encoding}
-release.ant.version=${ant.version}
+
+# Ensure consistent timestamps for reproducible builds
+ant.tstamp.now.iso=${tstamp.iso.release}
+
+# Reproducible builds require the use of the build tools defined below. The
+# vendors (where appropriate) and versions must match exactly for a reproducible
+# build since this data is embedded in various files, particularly JAR file
+# manifests, as part of the build process
+#
+# Apache Ant:      ${ant.version}
+#
+# Java Name:       ${java.vm.name}
+# Java Vendor:     ${java.vm.vendor}
+# Java Version:    ${java.vm.version}
+
+# The following is provided for information only. Builds will be repeatable
+# whether or not the build ennvironment in consistent with this information
+#
+# OS:              ${os.arch} ${os.name} ${os.version}
+# File encoding:   ${file.encoding}
+#
+# Release Manager: ${release.asfusername}
 </echo>
     <echo file="res/maven/mvn.properties">
 asf.ldap.username=${release.asfusername}


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org