[GitHub] [doris] AshinGau commented on a diff in pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.

["AshinGau (via GitHub)" <gi...@apache.org>]

AshinGau commented on code in PR #20998:
URL: https://github.com/apache/doris/pull/20998#discussion_r1234690651


##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1123,8 +1127,7 @@ Status OrcReader::_decode_string_dict_encoded_column(const std::string& col_name
             }
         }
     }
-    data_column->insert_many_strings_overflow(&string_values[0], string_values.size(),

Review Comment:
   Why change `insert_many_strings_overflow` as `insert_many_strings`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org