[jira] [Commented] (PIG-4365) TOP udf should implement Accumulator interface

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507782#comment-14507782 ] 

Rohini Palaniswamy commented on PIG-4365:
-----------------------------------------

[~eyal],
   Where it returns null before it now returns an empty bag. That needs to be fixed. Could you also add a test with actual pig script and small batch size so that the full code path is exercised in the test?  Refer TestAccumulator for example.

Can you also post the new patch in the review board (reviews.apache.org) as well?

> TOP udf should implement Accumulator interface
> ----------------------------------------------
>
>                 Key: PIG-4365
>                 URL: https://issues.apache.org/jira/browse/PIG-4365
>             Project: Pig
>          Issue Type: Task
>    Affects Versions: 0.15.0
>            Reporter: Rohini Palaniswamy
>            Assignee: Eyal Allweil
>              Labels: newbie
>             Fix For: 0.15.0
>
>         Attachments: PIG-4365.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)