You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/06/10 14:02:54 UTC

[PR] [FLINK-39879][tests] Avoid deploy RPC timeout in CheckpointAcknowledgeFailureITCase [flink]

MartijnVisser opened a new pull request, #28377:
URL: https://github.com/apache/flink/pull/28377

   ## What is the purpose of the change
   
   `CheckpointAcknowledgeFailureITCase.testCheckpointAckFailure` still fails on slow CI after the hang fix. The 250 ms `pekko.ask.timeout` set by the test is load-bearing (it forces the oversized checkpoint ACK to time out, which the test asserts on), but it is the cluster-wide RPC timeout and therefore also governs task deployment. On a slow machine the deployment ask itself exceeds 250 ms, so the job fails (recovery suppressed by `NoRestartBackoffTimeStrategy`) before the keyed state is updated.
   
   ## Brief change log
   
     - Raise `ASK_TIMEOUT` from 250 ms to 1 s. `CHECKPOINT_TIMEOUT` stays `ASK_TIMEOUT * 1000`, so the oversized ACK is still what times out and the `AskTimeoutException` assertion is unchanged, while task deployment gets headroom on slow CI.
   
   ## Verifying this change
   
   This change is already covered by the existing `testCheckpointAckFailure` assertion (the `AskTimeoutException` check is unchanged); it only removes a slow-CI deploy-timeout flake. Verified by running the test repeatedly locally.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Claude Opus 4.8 (1M context))
   
   Generated-by: Claude Opus 4.8 (1M context)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39879][tests] Avoid deploy RPC timeout in CheckpointAcknowledgeFailureITCase [flink]

Posted by "lihaosky (via GitHub)" <gi...@apache.org>.
lihaosky merged PR #28377:
URL: https://github.com/apache/flink/pull/28377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39879][tests] Avoid deploy RPC timeout in CheckpointAcknowledgeFailureITCase [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28377:
URL: https://github.com/apache/flink/pull/28377#issuecomment-4671162856

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1dad21916dcef905477cf0bd120f4dce9936748a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1dad21916dcef905477cf0bd120f4dce9936748a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1dad21916dcef905477cf0bd120f4dce9936748a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-39879][tests] Avoid deploy RPC timeout in CheckpointAcknowledgeFailureITCase [flink]

Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #28377:
URL: https://github.com/apache/flink/pull/28377#issuecomment-4699310505

   Hi, @MartijnVisser Could you help rebase the latest master branch ,then re-trigger the CI?
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org