You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dannymartinm (via GitHub)" <gi...@apache.org> on 2023/02/13 14:27:02 UTC

[GitHub] [beam] dannymartinm opened a new pull request, #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

dannymartinm opened a new pull request, #23136:
URL: https://github.com/apache/beam/pull/23136

   `DO NOT MERGE until the infrastructure is in place. Please talk to @dannymartinm @elink21  before merging`
   
   As part of the issue [21106](https://github.com/apache/beam/issues/21106), @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems. 
   
   Please see the Approved Pull Request ([PR#22703](https://github.com/apache/beam/pull/22703)) for reference.
   
   In this PR you will find the following changes: 
   
   * Updates in workflow Build Wheels  to `runs-on` self-hosted runners
       * Ubuntu
       * Windows
   
   
   [PR#16511 ](https://github.com/apache/beam/pull/16511): Previous PR for reference.
   [BEAM-12812](https://issues.apache.org/jira/browse/BEAM-12812): Original Jira may contain additional context. 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners
URL: https://github.com/apache/beam/pull/23136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm closed pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners
URL: https://github.com/apache/beam/pull/23136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23136:
URL: https://github.com/apache/beam/pull/23136#issuecomment-1413691025

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23136:
URL: https://github.com/apache/beam/pull/23136#issuecomment-1242327304

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23136:
URL: https://github.com/apache/beam/pull/23136#discussion_r969800892


##########
.github/workflows/build_wheels.yml:
##########
@@ -249,8 +254,8 @@ jobs:
         CIBW_BEFORE_BUILD: pip install cython && pip install --upgrade setuptools
       run: cibuildwheel --print-build-identifiers && cibuildwheel --output-dir wheelhouse
       shell: bash
-    - name: install sha512sum on MacOS
-      if: startsWith(matrix.os_python.os, 'macos')
+    - name: Install sha512sum on MacOS
+      if: contains(matrix.os_python.os, 'macos-latest')

Review Comment:
   I think this test isn't quite right - https://github.com/sre-apache-beam-dev/beam/actions/runs/3041505275/workflow#L258 - what I'm suggesting is that we keep `startsWith(matrix.os_python.os, 'macos')` - that tests `contains(matrix.os_python.os, 'macos')`
   
   With that said, because we're using arrays for the other cases I'm not sure how GHA will handle it (it'll try to cast them to strings, but that might blow up?). I'm fine leaving it as is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] dannymartinm commented on a diff in pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
dannymartinm commented on code in PR #23136:
URL: https://github.com/apache/beam/pull/23136#discussion_r969785896


##########
.github/workflows/build_wheels.yml:
##########
@@ -249,8 +254,8 @@ jobs:
         CIBW_BEFORE_BUILD: pip install cython && pip install --upgrade setuptools
       run: cibuildwheel --print-build-identifiers && cibuildwheel --output-dir wheelhouse
       shell: bash
-    - name: install sha512sum on MacOS
-      if: startsWith(matrix.os_python.os, 'macos')
+    - name: Install sha512sum on MacOS
+      if: contains(matrix.os_python.os, 'macos-latest')

Review Comment:
   As we have different operating systems and tags in the self-hosted runners, we added an array for pointing to the required runner `[[self-hosted, ubuntu-20.04], macos-latest, [self-hosted, windows-server-2019]]` instead of using strings. That's why we needed to change from `startsWith` to `contains`. 
   
   According to the [documentation](https://docs.github.com/en/actions/learn-github-actions/expressions#contains), `contains` only works
   
   > If search is an array, this function returns true if the item is an element in the array. 
   
   Forcing us to use the full word in the comparison in order to return `true`. 
   
   In the following, you can find some tests that we did yesterday using `macos-latest` and `macos`. 
   * [macos-latest](https://github.com/sre-apache-beam-dev/beam/actions/runs/3041599478/workflow#L258)
   * [macos](https://github.com/sre-apache-beam-dev/beam/actions/runs/3041505275/workflow#L258)
   
   Please let us know your comments.
   
   Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23136:
URL: https://github.com/apache/beam/pull/23136#issuecomment-1335150699

   Reminder, please take a look at this pr: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23136:
URL: https://github.com/apache/beam/pull/23136#issuecomment-1426758506

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] elink21 commented on pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
elink21 commented on PR #23136:
URL: https://github.com/apache/beam/pull/23136#issuecomment-1308954681

   Status update: reviewed by @damccorm, waiting for the migration window to deploy the infrastructure and request the merge. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #23136: [GitHub Actions] - Updates in Build Wheels to runs-on Self-hosted runners

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23136:
URL: https://github.com/apache/beam/pull/23136#discussion_r967402924


##########
.github/workflows/build_wheels.yml:
##########
@@ -249,8 +254,8 @@ jobs:
         CIBW_BEFORE_BUILD: pip install cython && pip install --upgrade setuptools
       run: cibuildwheel --print-build-identifiers && cibuildwheel --output-dir wheelhouse
       shell: bash
-    - name: install sha512sum on MacOS
-      if: startsWith(matrix.os_python.os, 'macos')
+    - name: Install sha512sum on MacOS
+      if: contains(matrix.os_python.os, 'macos-latest')

Review Comment:
   Any reason for this change? I think I like the previous version more because it is permissive if we eventually decide to pin to a specific macos version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org