[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7117: Substrait union/union all

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7117:
URL: https://github.com/apache/arrow-datafusion/pull/7117#discussion_r1277708289


##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -470,6 +471,27 @@ pub async fn from_substrait_rel(
                 "Only NamedTable reads are supported".to_string(),
             )),
         },
+        Some(RelType::Set(set)) => match set_rel::SetOp::from_i32(set.op) {
+            Some(set_op) => match set_op {
+                set_rel::SetOp::UnionAll => {
+                    assert!(!set.inputs.is_empty());

Review Comment:
   It might make sense to return an error here rather than assert / panic if the input is unexpected



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org