You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2005/11/03 05:13:55 UTC
Re: download report was: svn commit: r322514
I'm still really unconvinced about this report. It should be working on
information from the POM, not assembly descriptor - and I'm not sure how
much it adds over just typing up a quick APT right now.
Can we move it to the sandbox, then talk about what information to add
to the POM to make it effective? Perhaps elaboration next to downloadUrl
in distributionManagement.
There are problems with the current implementation:
- parsing out assembly plugin configuration ignores any defaults
- some projects don't have an assembly - the jar in the repo is their
distribution
Sorry that I hadn't replied earlier.
- Brett
Vincent Siveton wrote:
> Hi Brett,
>
> (Sorry for the delayed response)
>
> Putting the assembly report in project info reports is the logical way.
>
> To do this change, we need to change the visibility of some
> methods/attributes in the AssemblyMojo and AbstractUnpackingMojo
> classes (depending the package choose)
> Also, projectinfos plugins needs to have new deps.
>
> I ll try to do this shift ASAP, if, of course, everybody is ok.
> WDYT? Thanks.
>
> Cheers,
>
> Vincent
>
>
> 2005/10/23, Brett Porter <br...@apache.org>:
>
>>Vincent Massol wrote:
>>
>>>What does it do? Same as the download report in the m1 xdoc plugin?
>>
>>That's my understanding.
>>
>>
>>>It certainly doesn't go into the assembly plugin IMO. However it could
>>>possibly go in the release plugin or in the changes report or in the info
>>>plugin or ...
>>
>>I agree that it shouldn't be in assembly (nor release). I'd prefer to
>>keep functional plugins separate from report plugins within reason (due
>>to it requiring additional deps to be downloaded).
>>
>>For me, the project info report is the most natural home. IIRC there was
>>an issue with obtaining the correct location of the download though.
>>
>>- Brett
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: download report was: svn commit: r322514
Posted by Brett Porter <br...@apache.org>.
Thanks!
Vincent Siveton wrote:
> Hi Brett,
>
>> Vincent Siveton wrote:
>>>> Can we move it to the sandbox, then talk about what information to add
>>>> to the POM to make it effective? Perhaps elaboration next to
>> downloadUrl
>>>> in distributionManagement.
>>> +1
>> Hi Vincent,
>>
>> Were you going to make this move? I'd like to do this before nay further
>> releases of the assembly plugin...
>>
>
> Done in svn.
>
> I created a new maven plugin in sandbox:
> sandbox\plugins\maven-assembly-report-plugin
>
> Cheers,
>
> Vincent
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: download report was: svn commit: r322514
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Brett,
> Vincent Siveton wrote:
> >> Can we move it to the sandbox, then talk about what information to add
> >> to the POM to make it effective? Perhaps elaboration next to
> downloadUrl
> >> in distributionManagement.
> >
> > +1
>
> Hi Vincent,
>
> Were you going to make this move? I'd like to do this before nay further
> releases of the assembly plugin...
>
Done in svn.
I created a new maven plugin in sandbox:
sandbox\plugins\maven-assembly-report-plugin
Cheers,
Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: download report was: svn commit: r322514
Posted by Brett Porter <br...@apache.org>.
Vincent Siveton wrote:
>> Can we move it to the sandbox, then talk about what information to add
>> to the POM to make it effective? Perhaps elaboration next to downloadUrl
>> in distributionManagement.
>
> +1
Hi Vincent,
Were you going to make this move? I'd like to do this before nay further
releases of the assembly plugin...
Thanks,
Brett
>
>> There are problems with the current implementation:
>> - parsing out assembly plugin configuration ignores any defaults
>> - some projects don't have an assembly - the jar in the repo is their
>> distribution
>
> Good points.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: download report was: svn commit: r322514
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Brett,
> I'm still really unconvinced about this report. It should be working on
> information from the POM, not assembly descriptor - and I'm not sure how
Agree but actually supported formats are in the assembly descriptor.
> much it adds over just typing up a quick APT right now.
Maybe 5 minutes? ;)
> Can we move it to the sandbox, then talk about what information to add
> to the POM to make it effective? Perhaps elaboration next to downloadUrl
> in distributionManagement.
+1
> There are problems with the current implementation:
> - parsing out assembly plugin configuration ignores any defaults
> - some projects don't have an assembly - the jar in the repo is their
> distribution
Good points.
> Sorry that I hadn't replied earlier.
NP
Thanks for your support.
Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org