You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by janisz <gi...@git.apache.org> on 2017/09/13 20:37:34 UTC
[GitHub] mesos pull request #234: Display task state counters in the framework page.
GitHub user janisz opened a pull request:
https://github.com/apache/mesos/pull/234
Display task state counters in the framework page.
Fixes: [MESOS-7962](https://issues.apache.org/jira/browse/MESOS-7962)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janisz/mesos MESOS-7962/Display_task_state_counters_in_the_framework_page_of_the_webui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit c5906b08a62ade1442d435f5b7465a4031780f0d
Author: Tomasz Janiszewski <to...@allegrogroup.com>
Date: 2017-09-13T20:35:42Z
Display task state counters in the framework page.
Fixes: MESOS-7962
----
---
[GitHub] mesos issue #234: Display task state counters in the framework page.
Posted by lilysamimi <gi...@git.apache.org>.
Github user lilysamimi commented on the issue:
https://github.com/apache/mesos/pull/234
Would be interested in talking with the folks that created this UI component. I'm giving out $10 Amazon gift cards to individuals who participate in a user experience research study with me pertaining to the Mesos UI. Please DM me. I'm at MesosCon today and tomorrow and around the Mesosphere booth.
---
[GitHub] mesos pull request #234: Display task state counters in the framework page.
Posted by bmahler <gi...@git.apache.org>.
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/234#discussion_r140382123
--- Diff: src/webui/master/static/js/controllers.js ---
@@ -230,6 +230,34 @@
_.each(framework.unreachable_tasks, setTaskMetadata);
_.each(framework.completed_tasks, setTaskMetadata);
+ framework.running_tasks = 0;
--- End diff --
A TODO here for adding per-framework metrics so that we don't have to loop over the tasks would be great.
---
[GitHub] mesos pull request #234: Display task state counters in the framework page.
Posted by bmahler <gi...@git.apache.org>.
Github user bmahler commented on a diff in the pull request:
https://github.com/apache/mesos/pull/234#discussion_r140382041
--- Diff: src/webui/master/static/js/controllers.js ---
@@ -230,6 +230,34 @@
_.each(framework.unreachable_tasks, setTaskMetadata);
_.each(framework.completed_tasks, setTaskMetadata);
+ framework.running_tasks = 0;
+ framework.staging_tasks = 0;
+ framework.starting_tasks = 0;
+ framework.killing_tasks = 0;
+
+ _.each(framework.tasks, function(task) {
+ switch (task.state) {
+ case "TASK_RUNNING": framework.running_tasks++; break;
--- End diff --
Let's put running after starting.
---
[GitHub] mesos pull request #234: Display task state counters in the framework page.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/mesos/pull/234
---