You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2006/12/19 20:38:49 UTC
svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Author: wrowe
Date: Tue Dec 19 11:38:48 2006
New Revision: 488780
URL: http://svn.apache.org/viewvc?view=rev&rev=488780
Log:
Votes and Notes; the first four I would like to see applied before
tagging 1.2.4; add a better patch for the winnt mpm wait patch
that makes this reviewable (sometimes -U3 just isn't enough context.)
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=488780&r1=488779&r2=488780
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue Dec 19 11:38:48 2006
@@ -123,7 +123,7 @@
deflate output filter.
Alternately, substitute mod_deflate.c of trunk (at r483597) which maps
to the same result as the net patches.
- +1: rpluem, niq, jerenkrantz
+ +1: rpluem, niq, jerenkrantz, wrowe
* Allow htcacheclean and httxt2dbm to link apr/apr-util statically
like the older support programs.
@@ -133,6 +133,17 @@
http://mail-archives.apache.org/mod_mbox//httpd-dev/200609.mbox/%3c1404e5910609091218p84f4d2flc1000764b4966727@mail.gmail.com%3e
+1: trawick, wrowe, jerenkrantz
+ * mod_proxy: Log unlock errors (as we do with locking errors).
+ Add additional clarification on where the error occurred.
+ Trunk version of patch:
+ http://svn.apache.org/viewvc?view=rev&revision=484792
+ http://svn.apache.org/viewvc?view=rev&revision=484787
+ http://svn.apache.org/viewvc?view=rev&revision=484978
+ 2.2.x version of patch:
+ For r484787, see: http://people.apache.org/~jim/patches/lock.txt
+ otherwise, trunk version works.
+ +1: jim, rpluem, wrowe
+
PATCHES PROPOSED TO BACKPORT FROM TRUNK:
* mpm_winnt: Fix return values from wait_for_many_objects.
@@ -142,6 +153,8 @@
http://svn.apache.org/viewvc?view=rev&revision=428029
2.2.x version of patch:
Trunk version works
+ http://people.apache.org/~wrowe/mpm_winnt_waits.patch
+ is easier to read (-U8)
+1: mturk, wrowe
* Bundled PCRE: backport r381783 from trunk
@@ -216,17 +229,6 @@
jim says: the reason why we keep it is in case we
ever start using it. So we keep the framework in
that case. Make trunk backports easier.
-
- * mod_proxy: Log unlock errors (as we do with locking errors).
- Add additional clarification on where the error occurred.
- Trunk version of patch:
- http://svn.apache.org/viewvc?view=rev&revision=484792
- http://svn.apache.org/viewvc?view=rev&revision=484787
- http://svn.apache.org/viewvc?view=rev&revision=484978
- 2.2.x version of patch:
- For r484787, see: http://people.apache.org/~jim/patches/lock.txt
- otherwise, trunk version works.
- +1: jim, rpluem
* core: PR#37680
Fix NONBLOCK status of listening sockets on restart/graceful
Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> next time http://issues.apache.org/bugzilla/show_bug.cgi?id=37680
> would help so the fruit hangs even lower.
Thanks Jim!
> The other fatal bug is:
>
>> * mpm_winnt: Fix return values from wait_for_many_objects.
>> http://svn.apache.org/viewvc?view=rev&revision=428029
>> 2.2.x version of patch:
>> Trunk version works
>> + http://people.apache.org/~wrowe/mpm_winnt_waits.patch
>> + is easier to read (-U8)
>> +1: mturk, wrowe
>
> Which i've created another, easier-to-read example of the backport, if you
> didn't follow the change last time please read the new patch and chime in
> a third +1? You'll note it's simply a matter of unsetting errno before we
> invoke the wait, so we know if the 64th, 128th, etc are real errors or in
> fact indexes into the wait list array.
>
> That's it. I'd like to roll tonight so the vote can be closed by the 22nd.
I'd like to have was dependent on someone tossing in a vote here /shrug.
Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Issac Goldstand <ma...@beamartyr.net>.
If we're in backport season, I have a quick patch that I whipped up
yesterday to fix mod_disk_cache on 2.2.x on systems that have
APR_SENDFILE_ENABLED but EnableSendfile Off.
Issac
William A. Rowe, Jr. wrote:
> wrowe@apache.org wrote:
>> Votes and Notes; the first four I would like to see applied before
>> tagging 1.2.4; add a better patch for the winnt mpm wait patch
>> that makes this reviewable (sometimes -U3 just isn't enough context.)
>
> As Ruediger guessed and committed (thanks!) we are now two more patches down.
>
> htcacheclean and httxt2dbm was a considerable flaw (considered that they
> didn't behave as documented, and these utilities are supposed to be easily
> moved around from box to box or run from a remote machine) and I'm about
> to commit that.
>
> I see two final state bugs... I'm about to finish vetting niq's patch for
> listen reconfig which pegs httpd at 100% cpu
>
> * core: PR#37680
> Fix NONBLOCK status of listening sockets on restart/graceful
> http://svn.apache.org/viewvc?view=rev&revision=487901
> +1: niq
>
> someone please add a third voice on Nick's patch? I'm guessing nobody
> bothered, next time http://issues.apache.org/bugzilla/show_bug.cgi?id=37680
> would help so the fruit hangs even lower.
>
> The other fatal bug is:
>
>> * mpm_winnt: Fix return values from wait_for_many_objects.
>> http://svn.apache.org/viewvc?view=rev&revision=428029
>> 2.2.x version of patch:
>> Trunk version works
>> + http://people.apache.org/~wrowe/mpm_winnt_waits.patch
>> + is easier to read (-U8)
>> +1: mturk, wrowe
>
> Which i've created another, easier-to-read example of the backport, if you
> didn't follow the change last time please read the new patch and chime in
> a third +1? You'll note it's simply a matter of unsetting errno before we
> invoke the wait, so we know if the 64th, 128th, etc are real errors or in
> fact indexes into the wait list array.
>
> That's it. I'd like to roll tonight so the vote can be closed by the 22nd.
> If another patch today fixes a runaway cpu or platform fault I might fix,
> if it's behavioral/optimization I won't be holding for it. Those can go in
> the next 2 - 6 weeks whenever Jim rolls the release he's been aspiring to.
Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Nick Kew wrote:
> On Tue, 19 Dec 2006 16:34:24 -0600
> "William A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
>
>> I see two final state bugs... I'm about to finish vetting niq's patch
>> for listen reconfig which pegs httpd at 100% cpu
>
> For the record, not my patch. It's attached to the PR, and the
> contributor is currently acknowledged in /trunk/CHANGES
After I clicked send, I realized that :)
Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Nick Kew <ni...@webthing.com>.
On Tue, 19 Dec 2006 16:34:24 -0600
"William A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
> I see two final state bugs... I'm about to finish vetting niq's patch
> for listen reconfig which pegs httpd at 100% cpu
For the record, not my patch. It's attached to the PR, and the
contributor is currently acknowledged in /trunk/CHANGES
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
wrowe@apache.org wrote:
> Votes and Notes; the first four I would like to see applied before
> tagging 1.2.4; add a better patch for the winnt mpm wait patch
> that makes this reviewable (sometimes -U3 just isn't enough context.)
As Ruediger guessed and committed (thanks!) we are now two more patches down.
htcacheclean and httxt2dbm was a considerable flaw (considered that they
didn't behave as documented, and these utilities are supposed to be easily
moved around from box to box or run from a remote machine) and I'm about
to commit that.
I see two final state bugs... I'm about to finish vetting niq's patch for
listen reconfig which pegs httpd at 100% cpu
* core: PR#37680
Fix NONBLOCK status of listening sockets on restart/graceful
http://svn.apache.org/viewvc?view=rev&revision=487901
+1: niq
someone please add a third voice on Nick's patch? I'm guessing nobody
bothered, next time http://issues.apache.org/bugzilla/show_bug.cgi?id=37680
would help so the fruit hangs even lower.
The other fatal bug is:
> * mpm_winnt: Fix return values from wait_for_many_objects.
> http://svn.apache.org/viewvc?view=rev&revision=428029
> 2.2.x version of patch:
> Trunk version works
> + http://people.apache.org/~wrowe/mpm_winnt_waits.patch
> + is easier to read (-U8)
> +1: mturk, wrowe
Which i've created another, easier-to-read example of the backport, if you
didn't follow the change last time please read the new patch and chime in
a third +1? You'll note it's simply a matter of unsetting errno before we
invoke the wait, so we know if the 64th, 128th, etc are real errors or in
fact indexes into the wait list array.
That's it. I'd like to roll tonight so the vote can be closed by the 22nd.
If another patch today fixes a runaway cpu or platform fault I might fix,
if it's behavioral/optimization I won't be holding for it. Those can go in
the next 2 - 6 weeks whenever Jim rolls the release he's been aspiring to.