You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 20:49:58 UTC

[GitHub] [arrow] rok edited a comment on pull request #10176: ARROW-11759: [C++] Kernel to extract datetime components (year, month, day, etc) from timestamp type

rok edited a comment on pull request #10176:
URL: https://github.com/apache/arrow/pull/10176#issuecomment-854990475


   @jorisvandenbossche - I found the cause of the unit issue - it was [ the missing`break`](https://github.com/apache/arrow/pull/10176/files#diff-53850537a2f3f7977473b30241fdd3ddb35aa97269284c06471d9b0c599e2c59R425)s in a switch statement. Typical. :)
   
   I think all comments were addressed now but more eyeballs == better code :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org