You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/03 13:46:08 UTC

[GitHub] [flink] rmetzger opened a new pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

rmetzger opened a new pull request #12467:
URL: https://github.com/apache/flink/pull/12467


   ## What is the purpose of the change
   
   The PubSub e2e test is failing quite regularly on CI. This change is about improving the debuggability of the test. 
   
   This change also contains some cleanups. It does not touch the main connector code.
   
   ## Brief change log
   
   - fix licensing issue from copied code
   - change test to allow "Run until failure" in IntelliJ
   - log docker container output before stopping the container
   - add log output
   
   
   ## Verifying this change
   
   Covered by CI (I executed the test a few times here: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8123&view=logs&j=1f3ed471-1849-5d3c-a34c-19792af4ad16&t=2f5b54d0-1d28-5b01-d344-aa50ffe0cdf8) 
   
   I could not reproduce the error in 200 runs locally.
   
   ## Does this pull request potentially affect one of the following parts:
   
   test only change
   
   ## Documentation
   
   test only change
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #12467:
URL: https://github.com/apache/flink/pull/12467


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12467:
URL: https://github.com/apache/flink/pull/12467#issuecomment-638229148


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3fb13c034c2f456c6d77dfe0725efe2e2654c536 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12467:
URL: https://github.com/apache/flink/pull/12467#issuecomment-638919331


   Thank for your the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12467:
URL: https://github.com/apache/flink/pull/12467#issuecomment-638210592


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3fb13c034c2f456c6d77dfe0725efe2e2654c536 (Wed Jun 03 13:49:38 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12467:
URL: https://github.com/apache/flink/pull/12467#issuecomment-638229148


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2649",
       "triggerID" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3fb13c034c2f456c6d77dfe0725efe2e2654c536 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2649) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12467: [FLINK-16572] Clean up PubSub connector e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12467:
URL: https://github.com/apache/flink/pull/12467#issuecomment-638229148


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2649",
       "triggerID" : "3fb13c034c2f456c6d77dfe0725efe2e2654c536",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3fb13c034c2f456c6d77dfe0725efe2e2654c536 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2649) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org