You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Stefan Egli (JIRA)" <ji...@apache.org> on 2016/03/23 11:05:25 UTC

[jira] [Created] (OAK-4145) LeaseFailureHandler might be called multiple times/concurrently on a lease failure

Stefan Egli created OAK-4145:
--------------------------------

             Summary: LeaseFailureHandler might be called multiple times/concurrently on a lease failure
                 Key: OAK-4145
                 URL: https://issues.apache.org/jira/browse/OAK-4145
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: documentmk
    Affects Versions: 1.4.0
            Reporter: Stefan Egli
            Assignee: Stefan Egli
             Fix For: 1.6, 1.4.1


Due to the [retry loop in ClusterNodeInfo.performLeaseCheck|https://github.com/apache/jackrabbit-oak/blob/4b477d30f22bae8c24412dd123b232a1db33ec99/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/ClusterNodeInfo.java#L606] the previous mechanism to prevent multiple threads to call the LeaseFailureHandler is broken and you can now have multiple threads hit that retry-loop and all of them will call the LeaseFailureHandler in separate threads.

The consequences aren't grave as OSGi can handle concurrent {{bundle.stop()}} calls just fine.

But nevertheless, should we only call the LeaseFailureHandler only once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)