You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by dguy <gi...@git.apache.org> on 2016/11/03 18:51:19 UTC

[GitHub] kafka pull request #2097: KAFKA-4366: KafkaStreams.close() blocks indefinite...

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/2097

    KAFKA-4366: KafkaStreams.close() blocks indefinitely

    Added `timeout` and `timeUnit` to `KafkaStreams.close(..)`. Now do close on a thread and `join` that thread with the provided `timeout`.
    Changed `state` in `KafkaStreams` to use an enum.
    Added system test to ensure we don't deadlock on close when an uncaught exception handler that calls `System.exit(..)` is used and there is also a shutdown hook that calls `KafkaStreams.close(...)`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-4366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2097
    
----
commit 6dffa532ca0c065d2e67b812d82b3bdabe97b19d
Author: Damian Guy <da...@gmail.com>
Date:   2016-11-03T18:46:33Z

    add timeout to KafkaStreams.close(..)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2097: KAFKA-4366: KafkaStreams.close() blocks indefinite...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2097


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---