You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ac...@apache.org on 2020/01/19 15:50:45 UTC
[camel] branch master updated:
camel-eip-documentation-enricher-maven-plugin: Close OutputStream in
EipDocumentationEnricherMojo#saveToFile as reported by lgtm.com.
This is an automated email from the ASF dual-hosted git repository.
acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new a95ede1 camel-eip-documentation-enricher-maven-plugin: Close OutputStream in EipDocumentationEnricherMojo#saveToFile as reported by lgtm.com.
new 7b376c8 Merge pull request #3500 from PascalSchumacher/EipDocumentationEnricherMojo_close_OutputStream
a95ede1 is described below
commit a95ede1163642a0a097fca620b35d4de8f7ab57e
Author: Pascal Schumacher <pa...@gmx.net>
AuthorDate: Sun Jan 19 13:17:52 2020 +0100
camel-eip-documentation-enricher-maven-plugin: Close OutputStream in EipDocumentationEnricherMojo#saveToFile as reported by lgtm.com.
---
.../org/apache/camel/maven/EipDocumentationEnricherMojo.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tooling/maven/camel-eip-documentation-enricher-maven-plugin/src/main/java/org/apache/camel/maven/EipDocumentationEnricherMojo.java b/tooling/maven/camel-eip-documentation-enricher-maven-plugin/src/main/java/org/apache/camel/maven/EipDocumentationEnricherMojo.java
index c5c8654..3413b1b 100644
--- a/tooling/maven/camel-eip-documentation-enricher-maven-plugin/src/main/java/org/apache/camel/maven/EipDocumentationEnricherMojo.java
+++ b/tooling/maven/camel-eip-documentation-enricher-maven-plugin/src/main/java/org/apache/camel/maven/EipDocumentationEnricherMojo.java
@@ -234,10 +234,12 @@ public class EipDocumentationEnricherMojo extends AbstractMojo {
return baseType.replace("tns:", "");
}
- private void saveToFile(Document document, File outputFile, Transformer transformer) throws FileNotFoundException, TransformerException {
- StreamResult result = new StreamResult(new FileOutputStream(outputFile));
- DOMSource source = new DOMSource(document);
- transformer.transform(source, result);
+ private void saveToFile(Document document, File outputFile, Transformer transformer) throws FileNotFoundException, IOException, TransformerException {
+ try (FileOutputStream os = new FileOutputStream(outputFile)) {
+ StreamResult result = new StreamResult(os);
+ DOMSource source = new DOMSource(document);
+ transformer.transform(source, result);
+ }
}
private void validateIsFile(File file, String name) throws MojoExecutionException {