[GitHub] [helix] zhangmeng916 commented on a change in pull request #1124: (WIP)Add stale message map to improve P2P message rate

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #1124:
URL: https://github.com/apache/helix/pull/1124#discussion_r454120472



##########
File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
##########
@@ -544,6 +544,13 @@ public synchronized void setLiveInstances(List<LiveInstance> liveInstances) {
     return _instanceMessagesCache.getMessages(instanceName);
   }
 
+  public void setStaleMessages(Map<String, Map<String, Message>> staleMessageMap) {

Review comment:
       Yeah, it's never called. Originally I used it, but then I simplified the code, and it's not used any more. I've removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org