[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #47: !str Eagerly fails flow if the future is already failed.

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #47:
URL: https://github.com/apache/incubator-pekko/pull/47#discussion_r1281628977


##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/GraphStages.scala:
##########
@@ -381,27 +381,25 @@ import pekko.stream.stage._
     override def initialAttributes: Attributes = DefaultAttributes.futureSource
     override def createLogic(attr: Attributes) =
       new GraphStageLogic(shape) with OutHandler {
-        def onPull(): Unit = {
+        override def preStart(): Unit = {
           future.value match {
             case Some(completed) =>
               // optimization if the future is already completed
-              onFutureCompleted(completed)
+              handle(completed)

Review Comment:
   This will can break up some code, because we change the existing behavior. 
   @mdedetrich 
   
   The `FailedSource` failing the stream ASAP. but maybe not this one?
   
   Especially when combine it with `flatmapConcat` with parallism materialization.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org