You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/26 09:30:14 UTC
[GitHub] [flink] ruanhang1993 opened a new pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
ruanhang1993 opened a new pull request #18516:
URL: https://github.com/apache/flink/pull/18516
## What is the purpose of the change
This pull request adds savepoint and metric test cases in source suite of the connector testfram.
## Brief change log
- Add savepoint and metric test cases in the source suite of the connector testfram
- Change the tests in the Kafka and Pulsar connector
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 261b4214f31ad1c55b3cc6247676d8074476d032 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287)
* 6786529ead447c190faa0fe3d0fe3a151f87f0a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
}, {
"hash" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353",
"triggerID" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e38d73d82dc9ba396d483e9257e4244cf72ad0e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231921
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
+public class MetricQueryer {
+ private static final Logger LOG = LoggerFactory.getLogger(MetricQueryer.class);
+ private RestClient restClient;
+
+ public MetricQueryer(Configuration configuration, Executor executor)
+ throws ConfigurationException {
+ restClient = new RestClient(configuration, executor);
+ }
+
+ public JobDetailsInfo getJobDetails(TestEnvironment.Endpoint endpoint, JobID jobId)
+ throws Exception {
+ String jmAddress = endpoint.getAddress();
+ int jmPort = endpoint.getPort();
+
+ final JobMessageParameters params = new JobMessageParameters();
+ params.jobPathParameter.resolve(jobId);
+
+ return restClient
+ .sendRequest(
+ jmAddress,
+ jmPort,
+ JobDetailsHeaders.getInstance(),
+ params,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetricList(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId) throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetrics(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId, String filters)
+ throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ MetricsFilterParameter metricFilter =
+ (MetricsFilterParameter)
+ subtaskMetricsParameters.getQueryParameters().iterator().next();
+ metricFilter.resolveFromString(filters);
+
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public Double getMetricByRestApi(
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 261b4214f31ad1c55b3cc6247676d8074476d032 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287)
* 6786529ead447c190faa0fe3d0fe3a151f87f0a2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231978
##########
File path: flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarSourceITCase.java
##########
@@ -40,6 +42,9 @@
@TestExternalSystem
PulsarTestEnvironment pulsar = new PulsarTestEnvironment(PulsarRuntime.mock());
+ @Semantic
+ CheckpointingMode[] semantics = new CheckpointingMode[] {CheckpointingMode.EXACTLY_ONCE};
Review comment:
Actually, this semantic tests are contained in the sink tests for Kafka connector. There are not ITCase in the source now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang closed pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
leonardBang closed pull request #18516:
URL: https://github.com/apache/flink/pull/18516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231897
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -71,7 +82,18 @@ public MiniClusterTestEnvironment() {
@Override
public StreamExecutionEnvironment createExecutionEnvironment(
TestEnvironmentSettings envOptions) {
- return StreamExecutionEnvironment.getExecutionEnvironment();
+ Configuration configuration = new Configuration();
+ if (envOptions.getSavepointRestorePath() != null) {
+ configuration.set(SAVEPOINT_PATH, envOptions.getSavepointRestorePath());
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022022034
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 741b593b95d9501c69f8f7014729b0983350bfe7 (Wed Jan 26 09:33:53 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25288).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 741b593b95d9501c69f8f7014729b0983350bfe7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215)
* 64754bd5f4e51ea7679b67cceb7b49e0e86808f7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804792672
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/TestDataMatchers.java
##########
@@ -33,180 +36,194 @@
// ---------------------------- Matcher Builders ----------------------------------
public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
- List<List<T>> testRecordsLists) {
- return new MultipleSplitDataMatcher<>(testRecordsLists);
+ List<List<T>> testRecordsLists, CheckpointingMode semantic) {
+ return new MultipleSplitDataMatcher<>(testRecordsLists, semantic);
}
- public static <T> SingleSplitDataMatcher<T> matchesSplitTestData(List<T> testData) {
- return new SingleSplitDataMatcher<>(testData);
+ public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
+ List<List<T>> testRecordsLists,
+ CheckpointingMode semantic,
+ boolean testDataAllInResult) {
+ return new MultipleSplitDataMatcher<>(
+ testRecordsLists, MultipleSplitDataMatcher.UNSET, semantic, testDataAllInResult);
}
- public static <T> SingleSplitDataMatcher<T> matchesSplitTestData(List<T> testData, int limit) {
- return new SingleSplitDataMatcher<>(testData, limit);
+ public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
+ List<List<T>> testRecordsLists, Integer limit, CheckpointingMode semantic) {
+ if (limit == null) {
+ return new MultipleSplitDataMatcher<>(testRecordsLists, semantic);
+ }
+ return new MultipleSplitDataMatcher<>(testRecordsLists, limit, semantic);
}
// ---------------------------- Matcher Definitions --------------------------------
-
/**
- * Matcher for validating test data in a single split.
+ * Matcher for validating test data from multiple splits.
+ *
+ * <p>Each list has a pointer (iterator) pointing to current checking record. When a record is
+ * received in the stream, it will be compared to all current pointing records in lists, and the
+ * pointer to the identical record will move forward.
+ *
+ * <p>If the stream preserves the correctness and order of records in all splits, all pointers
+ * should reach the end of the list finally.
*
* @param <T> Type of validating record
*/
- public static class SingleSplitDataMatcher<T> extends TypeSafeDiagnosingMatcher<Iterator<T>> {
+ public static class MultipleSplitDataMatcher<T> extends Condition<Iterator<T>> {
+ private static final Logger LOG = LoggerFactory.getLogger(MultipleSplitDataMatcher.class);
+
private static final int UNSET = -1;
- private final List<T> testData;
- private final int limit;
+ List<TestRecords<T>> testRecordsLists = new ArrayList<>();
+ private List<List<T>> testData;
private String mismatchDescription = null;
+ private final int limit;
+ private final int testDataSize;
+ private final CheckpointingMode semantic;
+ private final boolean testDataAllInResult;
- public SingleSplitDataMatcher(List<T> testData) {
- this.testData = testData;
- this.limit = UNSET;
+ public MultipleSplitDataMatcher(List<List<T>> testData, CheckpointingMode semantic) {
+ this(testData, UNSET, semantic);
}
- public SingleSplitDataMatcher(List<T> testData, int limit) {
- if (limit > testData.size()) {
+ public MultipleSplitDataMatcher(
+ List<List<T>> testData, int limit, CheckpointingMode semantic) {
+ this(testData, limit, semantic, true);
+ }
+
+ public MultipleSplitDataMatcher(
+ List<List<T>> testData,
+ int limit,
+ CheckpointingMode semantic,
+ boolean testDataAllInResult) {
+ super();
+ int allSize = 0;
+ for (List<T> testRecordsList : testData) {
+ this.testRecordsLists.add(new TestRecords<>(testRecordsList));
+ allSize += testRecordsList.size();
+ }
+
+ if (limit > allSize) {
throw new IllegalArgumentException(
"Limit validation size should be less than number of test records");
}
+ this.testDataAllInResult = testDataAllInResult;
this.testData = testData;
+ this.semantic = semantic;
+ this.testDataSize = allSize;
this.limit = limit;
}
@Override
- protected boolean matchesSafely(Iterator<T> resultIterator, Description description) {
- if (mismatchDescription != null) {
- description.appendText(mismatchDescription);
- return false;
+ public boolean matches(Iterator<T> resultIterator) {
+ if (CheckpointingMode.AT_LEAST_ONCE.equals(semantic)) {
+ return matchAtLeastOnce(resultIterator);
}
+ return matchExactlyOnce(resultIterator);
+ }
- boolean dataMismatch = false;
- boolean sizeMismatch = false;
- String sizeMismatchDescription = "";
- String dataMismatchDescription = "";
+ protected boolean matchExactlyOnce(Iterator<T> resultIterator) {
int recordCounter = 0;
- for (T testRecord : testData) {
- if (!resultIterator.hasNext()) {
- sizeMismatchDescription =
- String.format(
- "Expected to have %d records in result, but only received %d records",
- limit == UNSET ? testData.size() : limit, recordCounter);
- sizeMismatch = true;
- break;
- }
- T resultRecord = resultIterator.next();
- if (!testRecord.equals(resultRecord)) {
- dataMismatchDescription =
- String.format(
- "Mismatched record at position %d: Expected '%s' but was '%s'",
- recordCounter, testRecord, resultRecord);
- dataMismatch = true;
+ while (resultIterator.hasNext()) {
+ final T record = resultIterator.next();
+ if (!matchThenNext(record)) {
+ if (recordCounter >= testDataSize) {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Expected to have exactly %d records in result, but received more records",
+ testRecordsLists.stream()
+ .mapToInt(list -> list.records.size())
+ .sum()),
+ resultIterator);
+ } else {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Unexpected record '%s' at position %d",
+ record, recordCounter),
+ resultIterator);
+ }
+ logError();
+ return false;
}
recordCounter++;
+
if (limit != UNSET && recordCounter >= limit) {
break;
}
}
-
- if (limit == UNSET && resultIterator.hasNext()) {
- sizeMismatchDescription =
- String.format(
- "Expected to have exactly %d records in result, "
- + "but result iterator hasn't reached the end",
- testData.size());
- sizeMismatch = true;
- }
-
- if (dataMismatch && sizeMismatch) {
- mismatchDescription = sizeMismatchDescription + " And " + dataMismatchDescription;
- return false;
- } else if (dataMismatch) {
- mismatchDescription = dataMismatchDescription;
- return false;
- } else if (sizeMismatch) {
- mismatchDescription = sizeMismatchDescription;
+ if (limit == UNSET && !hasReachedEnd()) {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Expected to have exactly %d records in result, but only received %d records",
+ testRecordsLists.stream()
+ .mapToInt(list -> list.records.size())
+ .sum(),
+ recordCounter),
+ resultIterator);
+ logError();
return false;
} else {
return true;
}
}
- @Override
- public void describeTo(Description description) {
- description.appendText(
- "Records consumed by Flink should be identical to test data "
- + "and preserve the order in split");
- }
- }
-
- /**
- * Matcher for validating test data from multiple splits.
- *
- * <p>Each list has a pointer (iterator) pointing to current checking record. When a record is
- * received in the stream, it will be compared to all current pointing records in lists, and the
- * pointer to the identical record will move forward.
- *
- * <p>If the stream preserves the correctness and order of records in all splits, all pointers
- * should reach the end of the list finally.
- *
- * @param <T> Type of validating record
- */
- public static class MultipleSplitDataMatcher<T> extends TypeSafeDiagnosingMatcher<Iterator<T>> {
-
- List<TestRecords<T>> testRecordsLists = new ArrayList<>();
-
- private String mismatchDescription = null;
-
- public MultipleSplitDataMatcher(List<List<T>> testData) {
- for (List<T> testRecordsList : testData) {
- this.testRecordsLists.add(new TestRecords<>(testRecordsList));
- }
- }
-
- @Override
- protected boolean matchesSafely(Iterator<T> resultIterator, Description description) {
- if (mismatchDescription != null) {
- description.appendText(mismatchDescription);
- return false;
- }
+ protected boolean matchAtLeastOnce(Iterator<T> resultIterator) {
Review comment:
This has been fixed in PR #18547 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
* 261b4214f31ad1c55b3cc6247676d8074476d032 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231859
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainerTestEnvironment.java
##########
@@ -68,6 +71,7 @@ public FlinkContainerTestEnvironment(
config.set(HEARTBEAT_INTERVAL, 1000L);
config.set(HEARTBEAT_TIMEOUT, 5000L);
config.set(SLOT_REQUEST_TIMEOUT, 10000L);
+ config.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64754bd5f4e51ea7679b67cceb7b49e0e86808f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372)
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 741b593b95d9501c69f8f7014729b0983350bfe7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215)
* 64754bd5f4e51ea7679b67cceb7b49e0e86808f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1033281694
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231905
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang closed pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
leonardBang closed pull request #18516:
URL: https://github.com/apache/flink/pull/18516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64754bd5f4e51ea7679b67cceb7b49e0e86808f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64754bd5f4e51ea7679b67cceb7b49e0e86808f7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372)
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1034640876
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6786529ead447c190faa0fe3d0fe3a151f87f0a2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231841
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaSourceExternalContext.java
##########
@@ -58,20 +58,20 @@
public class KafkaSourceExternalContext implements DataStreamSourceExternalContext<String> {
private static final Logger LOG = LoggerFactory.getLogger(KafkaSourceExternalContext.class);
- private static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
- private static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
- private static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
+ protected static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
+ protected static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
+ protected static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
private static final int NUM_RECORDS_UPPER_BOUND = 500;
private static final int NUM_RECORDS_LOWER_BOUND = 100;
private final List<URL> connectorJarPaths;
- private final String bootstrapServers;
- private final String topicName;
- private final SplitMappingMode splitMappingMode;
- private final AdminClient adminClient;
+ protected final String bootstrapServers;
+ protected final String topicName;
+ protected final SplitMappingMode splitMappingMode;
+ protected final AdminClient adminClient;
Review comment:
This is invoked in another PR. I will revert this.
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainerTestEnvironment.java
##########
@@ -68,6 +71,7 @@ public FlinkContainerTestEnvironment(
config.set(HEARTBEAT_INTERVAL, 1000L);
config.set(HEARTBEAT_TIMEOUT, 5000L);
config.set(SLOT_REQUEST_TIMEOUT, 10000L);
+ config.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
fixed
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -53,9 +61,12 @@
private boolean isStarted = false;
public MiniClusterTestEnvironment() {
+ Configuration conf = new Configuration();
+ conf.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
fixed
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -71,7 +82,18 @@ public MiniClusterTestEnvironment() {
@Override
public StreamExecutionEnvironment createExecutionEnvironment(
TestEnvironmentSettings envOptions) {
- return StreamExecutionEnvironment.getExecutionEnvironment();
+ Configuration configuration = new Configuration();
+ if (envOptions.getSavepointRestorePath() != null) {
+ configuration.set(SAVEPOINT_PATH, envOptions.getSavepointRestorePath());
Review comment:
fixed
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
Review comment:
fixed
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
+public class MetricQueryer {
+ private static final Logger LOG = LoggerFactory.getLogger(MetricQueryer.class);
+ private RestClient restClient;
+
+ public MetricQueryer(Configuration configuration, Executor executor)
+ throws ConfigurationException {
+ restClient = new RestClient(configuration, executor);
+ }
+
+ public JobDetailsInfo getJobDetails(TestEnvironment.Endpoint endpoint, JobID jobId)
+ throws Exception {
+ String jmAddress = endpoint.getAddress();
+ int jmPort = endpoint.getPort();
+
+ final JobMessageParameters params = new JobMessageParameters();
+ params.jobPathParameter.resolve(jobId);
+
+ return restClient
+ .sendRequest(
+ jmAddress,
+ jmPort,
+ JobDetailsHeaders.getInstance(),
+ params,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetricList(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId) throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetrics(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId, String filters)
+ throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ MetricsFilterParameter metricFilter =
+ (MetricsFilterParameter)
+ subtaskMetricsParameters.getQueryParameters().iterator().next();
+ metricFilter.resolveFromString(filters);
+
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public Double getMetricByRestApi(
Review comment:
fixed
##########
File path: flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarSourceITCase.java
##########
@@ -40,6 +42,9 @@
@TestExternalSystem
PulsarTestEnvironment pulsar = new PulsarTestEnvironment(PulsarRuntime.mock());
+ @Semantic
+ CheckpointingMode[] semantics = new CheckpointingMode[] {CheckpointingMode.EXACTLY_ONCE};
Review comment:
Actually, this semantic tests are contained in the sink tests for Kafka connector. There are not ITCase in the source now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1035903673
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1035954652
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
* 261b4214f31ad1c55b3cc6247676d8074476d032 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231841
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaSourceExternalContext.java
##########
@@ -58,20 +58,20 @@
public class KafkaSourceExternalContext implements DataStreamSourceExternalContext<String> {
private static final Logger LOG = LoggerFactory.getLogger(KafkaSourceExternalContext.class);
- private static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
- private static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
- private static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
+ protected static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
+ protected static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
+ protected static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
private static final int NUM_RECORDS_UPPER_BOUND = 500;
private static final int NUM_RECORDS_LOWER_BOUND = 100;
private final List<URL> connectorJarPaths;
- private final String bootstrapServers;
- private final String topicName;
- private final SplitMappingMode splitMappingMode;
- private final AdminClient adminClient;
+ protected final String bootstrapServers;
+ protected final String topicName;
+ protected final SplitMappingMode splitMappingMode;
+ protected final AdminClient adminClient;
Review comment:
This is invoked in another PR. I will revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231864
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -53,9 +61,12 @@
private boolean isStarted = false;
public MiniClusterTestEnvironment() {
+ Configuration conf = new Configuration();
+ conf.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1034423301
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
}, {
"hash" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353",
"triggerID" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"triggerType" : "PUSH"
}, {
"hash" : "d8f797364383c4353d4637957693969c2497591b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8f797364383c4353d4637957693969c2497591b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e38d73d82dc9ba396d483e9257e4244cf72ad0e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353)
* d8f797364383c4353d4637957693969c2497591b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
}, {
"hash" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353",
"triggerID" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"triggerType" : "PUSH"
}, {
"hash" : "d8f797364383c4353d4637957693969c2497591b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31445",
"triggerID" : "d8f797364383c4353d4637957693969c2497591b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8f797364383c4353d4637957693969c2497591b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 741b593b95d9501c69f8f7014729b0983350bfe7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 741b593b95d9501c69f8f7014729b0983350bfe7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804806453
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java
##########
@@ -86,6 +103,8 @@
public abstract class SourceTestSuiteBase<T> {
private static final Logger LOG = LoggerFactory.getLogger(SourceTestSuiteBase.class);
+ static ExecutorService executorService =
+ Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors() * 2);
Review comment:
I will remove this field in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804792989
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/TestUtils.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.connector.testframe.external.ExternalSystemDataReader;
+import org.apache.flink.streaming.api.CheckpointingMode;
+
+import java.io.File;
+import java.io.IOException;
+import java.math.BigDecimal;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.attribute.FileAttribute;
+import java.time.Duration;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.streaming.api.CheckpointingMode.AT_LEAST_ONCE;
+import static org.apache.flink.streaming.api.CheckpointingMode.EXACTLY_ONCE;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/** Test utils. */
+public class TestUtils {
+ public static File newFolder(Path path) throws IOException {
+ Path tempPath = Files.createTempDirectory(path, "testing-framework", new FileAttribute[0]);
+ return tempPath.toFile();
+ }
+
+ public static <T> List<T> appendResultData(
+ List<T> result,
+ ExternalSystemDataReader<T> reader,
+ List<T> expected,
+ int retryTimes,
+ CheckpointingMode semantic) {
+ long timeoutMs = 1000L;
+ int retryIndex = 0;
+ if (EXACTLY_ONCE.equals(semantic)) {
+ while (retryIndex++ < retryTimes && result.size() < expected.size()) {
+ result.addAll(reader.poll(Duration.ofMillis(timeoutMs)));
+ }
+ return result;
+ } else if (AT_LEAST_ONCE.equals(semantic)) {
+ while (retryIndex++ < retryTimes && !containSameVal(expected, result, semantic)) {
+ result.addAll(reader.poll(Duration.ofMillis(timeoutMs)));
+ }
+ return result;
+ }
+ throw new IllegalStateException(
+ String.format("%s delivery guarantee doesn't support test.", semantic.name()));
+ }
Review comment:
Yes, I will remove these useless codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804794835
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/test/java/org/apache/flink/connector/testframe/utils/TestDataMatchersTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.streaming.api.CheckpointingMode;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** Unit test for {@link TestDataMatchers}. */
+public class TestDataMatchersTest {
Review comment:
This has been fixed in PR #18547 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 261b4214f31ad1c55b3cc6247676d8074476d032 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30215",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
}, {
"hash" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30372",
"triggerID" : "64754bd5f4e51ea7679b67cceb7b49e0e86808f7",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"triggerType" : "PUSH"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1033281694",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034423301",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1034640876",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035903673",
"triggerType" : "MANUAL"
}, {
"hash" : "42bf48fdbba63580ec0d5418579e2e65c413cf38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30475",
"triggerID" : "1035954652",
"triggerType" : "MANUAL"
}, {
"hash" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31287",
"triggerID" : "261b4214f31ad1c55b3cc6247676d8074476d032",
"triggerType" : "PUSH"
}, {
"hash" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31340",
"triggerID" : "6786529ead447c190faa0fe3d0fe3a151f87f0a2",
"triggerType" : "PUSH"
}, {
"hash" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353",
"triggerID" : "8e38d73d82dc9ba396d483e9257e4244cf72ad0e",
"triggerType" : "PUSH"
}, {
"hash" : "d8f797364383c4353d4637957693969c2497591b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31445",
"triggerID" : "d8f797364383c4353d4637957693969c2497591b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e38d73d82dc9ba396d483e9257e4244cf72ad0e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31353)
* d8f797364383c4353d4637957693969c2497591b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ruanhang1993 commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804782612
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/junit/annotations/Semantic.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.junit.annotations;
+
+import org.apache.flink.annotation.Experimental;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Marks the field in test class defining supported semantic: {@link
+ * org.apache.flink.streaming.api.CheckpointingMode}.
+ *
+ * <p>Only one field can be annotated in test class.
+ */
+@Target(ElementType.FIELD)
+@Retention(RetentionPolicy.RUNTIME)
+@Experimental
+public @interface Semantic {}
Review comment:
Yes, we could use like this.
The changes about the semantic tests are in the PR #18547. I think this change could be applied in that PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r804510698
##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroBulkFormatITCase.java
##########
@@ -64,6 +66,10 @@
private static final RowDataSerializer SERIALIZER = new RowDataSerializer(ROW_TYPE);
+ @SuppressWarnings("unused")
Review comment:
hint: add `@SuppressWarnings("unused")` for all unused annotation fields
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -71,7 +82,18 @@ public MiniClusterTestEnvironment() {
@Override
public StreamExecutionEnvironment createExecutionEnvironment(
TestEnvironmentSettings envOptions) {
- return StreamExecutionEnvironment.getExecutionEnvironment();
+ Configuration configuration = new Configuration();
+ if (envOptions.getSavepointRestorePath() != null) {
+ configuration.set(SAVEPOINT_PATH, envOptions.getSavepointRestorePath());
Review comment:
```suggestion
configuration.setString(SAVEPOINT_PATH, envOptions.getSavepointRestorePath());
```
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/environment/MiniClusterTestEnvironment.java
##########
@@ -53,9 +61,12 @@
private boolean isStarted = false;
public MiniClusterTestEnvironment() {
+ Configuration conf = new Configuration();
+ conf.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
minor: Use constant for specific test configuration value.
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainerTestEnvironment.java
##########
@@ -68,6 +71,7 @@ public FlinkContainerTestEnvironment(
config.set(HEARTBEAT_INTERVAL, 1000L);
config.set(HEARTBEAT_TIMEOUT, 5000L);
config.set(SLOT_REQUEST_TIMEOUT, 10000L);
+ config.set(METRIC_FETCHER_UPDATE_INTERVAL, 1000L);
Review comment:
We can use constant to maintain these magic number, these are used for tests with default constant value IIUC.
btw, Could connector developer pass custom Configuration?
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaSourceExternalContext.java
##########
@@ -58,20 +58,20 @@
public class KafkaSourceExternalContext implements DataStreamSourceExternalContext<String> {
private static final Logger LOG = LoggerFactory.getLogger(KafkaSourceExternalContext.class);
- private static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
- private static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
- private static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
+ protected static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
+ protected static final Pattern TOPIC_NAME_PATTERN = Pattern.compile(TOPIC_NAME_PREFIX + ".*");
+ protected static final String GROUP_ID_PREFIX = "kafka-source-external-context-";
private static final int NUM_RECORDS_UPPER_BOUND = 500;
private static final int NUM_RECORDS_LOWER_BOUND = 100;
private final List<URL> connectorJarPaths;
- private final String bootstrapServers;
- private final String topicName;
- private final SplitMappingMode splitMappingMode;
- private final AdminClient adminClient;
+ protected final String bootstrapServers;
+ protected final String topicName;
+ protected final SplitMappingMode splitMappingMode;
+ protected final AdminClient adminClient;
Review comment:
Do we need to change this privilege? I didn't find any child visit this.
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/junit/annotations/Semantic.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.junit.annotations;
+
+import org.apache.flink.annotation.Experimental;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Marks the field in test class defining supported semantic: {@link
+ * org.apache.flink.streaming.api.CheckpointingMode}.
+ *
+ * <p>Only one field can be annotated in test class.
+ */
+@Target(ElementType.FIELD)
+@Retention(RetentionPolicy.RUNTIME)
+@Experimental
+public @interface Semantic {}
Review comment:
```suggestion
public @interface TestSemantics {}
```
We can use this in following way IIUC, right ?
```
@TestSemantics
CheckpointingMode[] testSemantics = new CheckpointingMode[] {CheckpointingMode.EXACTLY_ONCE, CheckpointingMode.AT_LEAST_ONCE};
```
```
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
Review comment:
```suggestion
/** The querier used to get job metrics by rest API. */
```
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/TestUtils.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.connector.testframe.external.ExternalSystemDataReader;
+import org.apache.flink.streaming.api.CheckpointingMode;
+
+import java.io.File;
+import java.io.IOException;
+import java.math.BigDecimal;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.attribute.FileAttribute;
+import java.time.Duration;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.streaming.api.CheckpointingMode.AT_LEAST_ONCE;
+import static org.apache.flink.streaming.api.CheckpointingMode.EXACTLY_ONCE;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/** Test utils. */
+public class TestUtils {
+ public static File newFolder(Path path) throws IOException {
+ Path tempPath = Files.createTempDirectory(path, "testing-framework", new FileAttribute[0]);
+ return tempPath.toFile();
+ }
+
+ public static <T> List<T> appendResultData(
+ List<T> result,
+ ExternalSystemDataReader<T> reader,
+ List<T> expected,
+ int retryTimes,
+ CheckpointingMode semantic) {
+ long timeoutMs = 1000L;
+ int retryIndex = 0;
+ if (EXACTLY_ONCE.equals(semantic)) {
+ while (retryIndex++ < retryTimes && result.size() < expected.size()) {
+ result.addAll(reader.poll(Duration.ofMillis(timeoutMs)));
+ }
+ return result;
+ } else if (AT_LEAST_ONCE.equals(semantic)) {
+ while (retryIndex++ < retryTimes && !containSameVal(expected, result, semantic)) {
+ result.addAll(reader.poll(Duration.ofMillis(timeoutMs)));
+ }
+ return result;
+ }
+ throw new IllegalStateException(
+ String.format("%s delivery guarantee doesn't support test.", semantic.name()));
+ }
Review comment:
These methods never used ?
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/MetricQueryer.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.testframe.environment.TestEnvironment;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
+import org.apache.flink.runtime.rest.messages.JobMessageParameters;
+import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
+import org.apache.flink.runtime.rest.messages.MessagePathParameter;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsHeaders;
+import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedMetricsResponseBody;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsHeaders;
+import org.apache.flink.runtime.rest.messages.job.metrics.AggregatedSubtaskMetricsParameters;
+import org.apache.flink.runtime.rest.messages.job.metrics.MetricsFilterParameter;
+import org.apache.flink.util.ConfigurationException;
+import org.apache.flink.util.StringUtils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.concurrent.Executor;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** The queryer is used to get job metrics by rest API. */
+public class MetricQueryer {
+ private static final Logger LOG = LoggerFactory.getLogger(MetricQueryer.class);
+ private RestClient restClient;
+
+ public MetricQueryer(Configuration configuration, Executor executor)
+ throws ConfigurationException {
+ restClient = new RestClient(configuration, executor);
+ }
+
+ public JobDetailsInfo getJobDetails(TestEnvironment.Endpoint endpoint, JobID jobId)
+ throws Exception {
+ String jmAddress = endpoint.getAddress();
+ int jmPort = endpoint.getPort();
+
+ final JobMessageParameters params = new JobMessageParameters();
+ params.jobPathParameter.resolve(jobId);
+
+ return restClient
+ .sendRequest(
+ jmAddress,
+ jmPort,
+ JobDetailsHeaders.getInstance(),
+ params,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetricList(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId) throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public AggregatedMetricsResponseBody getMetrics(
+ TestEnvironment.Endpoint endpoint, JobID jobId, JobVertexID vertexId, String filters)
+ throws Exception {
+ AggregatedSubtaskMetricsParameters subtaskMetricsParameters =
+ new AggregatedSubtaskMetricsParameters();
+ Iterator<MessagePathParameter<?>> pathParams =
+ subtaskMetricsParameters.getPathParameters().iterator();
+ ((JobIDPathParameter) pathParams.next()).resolve(jobId);
+ ((JobVertexIdPathParameter) pathParams.next()).resolve(vertexId);
+ MetricsFilterParameter metricFilter =
+ (MetricsFilterParameter)
+ subtaskMetricsParameters.getQueryParameters().iterator().next();
+ metricFilter.resolveFromString(filters);
+
+ return restClient
+ .sendRequest(
+ endpoint.getAddress(),
+ endpoint.getPort(),
+ AggregatedSubtaskMetricsHeaders.getInstance(),
+ subtaskMetricsParameters,
+ EmptyRequestBody.getInstance())
+ .get(30, TimeUnit.SECONDS);
+ }
+
+ public Double getMetricByRestApi(
Review comment:
Maybe `getAggregatedMetricsByRestAPI` is more accurate as the function returns `Double` type value.
##########
File path: flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarSourceITCase.java
##########
@@ -40,6 +42,9 @@
@TestExternalSystem
PulsarTestEnvironment pulsar = new PulsarTestEnvironment(PulsarRuntime.mock());
+ @Semantic
+ CheckpointingMode[] semantics = new CheckpointingMode[] {CheckpointingMode.EXACTLY_ONCE};
Review comment:
I didn't find any ITCase for `CheckpointingMode.AT_LEAST_ONCE`, we need add some case as we introduced the semantics supports.
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/utils/TestDataMatchers.java
##########
@@ -33,180 +36,194 @@
// ---------------------------- Matcher Builders ----------------------------------
public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
- List<List<T>> testRecordsLists) {
- return new MultipleSplitDataMatcher<>(testRecordsLists);
+ List<List<T>> testRecordsLists, CheckpointingMode semantic) {
+ return new MultipleSplitDataMatcher<>(testRecordsLists, semantic);
}
- public static <T> SingleSplitDataMatcher<T> matchesSplitTestData(List<T> testData) {
- return new SingleSplitDataMatcher<>(testData);
+ public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
+ List<List<T>> testRecordsLists,
+ CheckpointingMode semantic,
+ boolean testDataAllInResult) {
+ return new MultipleSplitDataMatcher<>(
+ testRecordsLists, MultipleSplitDataMatcher.UNSET, semantic, testDataAllInResult);
}
- public static <T> SingleSplitDataMatcher<T> matchesSplitTestData(List<T> testData, int limit) {
- return new SingleSplitDataMatcher<>(testData, limit);
+ public static <T> MultipleSplitDataMatcher<T> matchesMultipleSplitTestData(
+ List<List<T>> testRecordsLists, Integer limit, CheckpointingMode semantic) {
+ if (limit == null) {
+ return new MultipleSplitDataMatcher<>(testRecordsLists, semantic);
+ }
+ return new MultipleSplitDataMatcher<>(testRecordsLists, limit, semantic);
}
// ---------------------------- Matcher Definitions --------------------------------
-
/**
- * Matcher for validating test data in a single split.
+ * Matcher for validating test data from multiple splits.
+ *
+ * <p>Each list has a pointer (iterator) pointing to current checking record. When a record is
+ * received in the stream, it will be compared to all current pointing records in lists, and the
+ * pointer to the identical record will move forward.
+ *
+ * <p>If the stream preserves the correctness and order of records in all splits, all pointers
+ * should reach the end of the list finally.
*
* @param <T> Type of validating record
*/
- public static class SingleSplitDataMatcher<T> extends TypeSafeDiagnosingMatcher<Iterator<T>> {
+ public static class MultipleSplitDataMatcher<T> extends Condition<Iterator<T>> {
+ private static final Logger LOG = LoggerFactory.getLogger(MultipleSplitDataMatcher.class);
+
private static final int UNSET = -1;
- private final List<T> testData;
- private final int limit;
+ List<TestRecords<T>> testRecordsLists = new ArrayList<>();
+ private List<List<T>> testData;
private String mismatchDescription = null;
+ private final int limit;
+ private final int testDataSize;
+ private final CheckpointingMode semantic;
+ private final boolean testDataAllInResult;
- public SingleSplitDataMatcher(List<T> testData) {
- this.testData = testData;
- this.limit = UNSET;
+ public MultipleSplitDataMatcher(List<List<T>> testData, CheckpointingMode semantic) {
+ this(testData, UNSET, semantic);
}
- public SingleSplitDataMatcher(List<T> testData, int limit) {
- if (limit > testData.size()) {
+ public MultipleSplitDataMatcher(
+ List<List<T>> testData, int limit, CheckpointingMode semantic) {
+ this(testData, limit, semantic, true);
+ }
+
+ public MultipleSplitDataMatcher(
+ List<List<T>> testData,
+ int limit,
+ CheckpointingMode semantic,
+ boolean testDataAllInResult) {
+ super();
+ int allSize = 0;
+ for (List<T> testRecordsList : testData) {
+ this.testRecordsLists.add(new TestRecords<>(testRecordsList));
+ allSize += testRecordsList.size();
+ }
+
+ if (limit > allSize) {
throw new IllegalArgumentException(
"Limit validation size should be less than number of test records");
}
+ this.testDataAllInResult = testDataAllInResult;
this.testData = testData;
+ this.semantic = semantic;
+ this.testDataSize = allSize;
this.limit = limit;
}
@Override
- protected boolean matchesSafely(Iterator<T> resultIterator, Description description) {
- if (mismatchDescription != null) {
- description.appendText(mismatchDescription);
- return false;
+ public boolean matches(Iterator<T> resultIterator) {
+ if (CheckpointingMode.AT_LEAST_ONCE.equals(semantic)) {
+ return matchAtLeastOnce(resultIterator);
}
+ return matchExactlyOnce(resultIterator);
+ }
- boolean dataMismatch = false;
- boolean sizeMismatch = false;
- String sizeMismatchDescription = "";
- String dataMismatchDescription = "";
+ protected boolean matchExactlyOnce(Iterator<T> resultIterator) {
int recordCounter = 0;
- for (T testRecord : testData) {
- if (!resultIterator.hasNext()) {
- sizeMismatchDescription =
- String.format(
- "Expected to have %d records in result, but only received %d records",
- limit == UNSET ? testData.size() : limit, recordCounter);
- sizeMismatch = true;
- break;
- }
- T resultRecord = resultIterator.next();
- if (!testRecord.equals(resultRecord)) {
- dataMismatchDescription =
- String.format(
- "Mismatched record at position %d: Expected '%s' but was '%s'",
- recordCounter, testRecord, resultRecord);
- dataMismatch = true;
+ while (resultIterator.hasNext()) {
+ final T record = resultIterator.next();
+ if (!matchThenNext(record)) {
+ if (recordCounter >= testDataSize) {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Expected to have exactly %d records in result, but received more records",
+ testRecordsLists.stream()
+ .mapToInt(list -> list.records.size())
+ .sum()),
+ resultIterator);
+ } else {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Unexpected record '%s' at position %d",
+ record, recordCounter),
+ resultIterator);
+ }
+ logError();
+ return false;
}
recordCounter++;
+
if (limit != UNSET && recordCounter >= limit) {
break;
}
}
-
- if (limit == UNSET && resultIterator.hasNext()) {
- sizeMismatchDescription =
- String.format(
- "Expected to have exactly %d records in result, "
- + "but result iterator hasn't reached the end",
- testData.size());
- sizeMismatch = true;
- }
-
- if (dataMismatch && sizeMismatch) {
- mismatchDescription = sizeMismatchDescription + " And " + dataMismatchDescription;
- return false;
- } else if (dataMismatch) {
- mismatchDescription = dataMismatchDescription;
- return false;
- } else if (sizeMismatch) {
- mismatchDescription = sizeMismatchDescription;
+ if (limit == UNSET && !hasReachedEnd()) {
+ this.mismatchDescription =
+ generateMismatchDescription(
+ String.format(
+ "Expected to have exactly %d records in result, but only received %d records",
+ testRecordsLists.stream()
+ .mapToInt(list -> list.records.size())
+ .sum(),
+ recordCounter),
+ resultIterator);
+ logError();
return false;
} else {
return true;
}
}
- @Override
- public void describeTo(Description description) {
- description.appendText(
- "Records consumed by Flink should be identical to test data "
- + "and preserve the order in split");
- }
- }
-
- /**
- * Matcher for validating test data from multiple splits.
- *
- * <p>Each list has a pointer (iterator) pointing to current checking record. When a record is
- * received in the stream, it will be compared to all current pointing records in lists, and the
- * pointer to the identical record will move forward.
- *
- * <p>If the stream preserves the correctness and order of records in all splits, all pointers
- * should reach the end of the list finally.
- *
- * @param <T> Type of validating record
- */
- public static class MultipleSplitDataMatcher<T> extends TypeSafeDiagnosingMatcher<Iterator<T>> {
-
- List<TestRecords<T>> testRecordsLists = new ArrayList<>();
-
- private String mismatchDescription = null;
-
- public MultipleSplitDataMatcher(List<List<T>> testData) {
- for (List<T> testRecordsList : testData) {
- this.testRecordsLists.add(new TestRecords<>(testRecordsList));
- }
- }
-
- @Override
- protected boolean matchesSafely(Iterator<T> resultIterator, Description description) {
- if (mismatchDescription != null) {
- description.appendText(mismatchDescription);
- return false;
- }
+ protected boolean matchAtLeastOnce(Iterator<T> resultIterator) {
Review comment:
Add unit test for `AtLeastOnce` case ?
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java
##########
@@ -86,6 +103,8 @@
public abstract class SourceTestSuiteBase<T> {
private static final Logger LOG = LoggerFactory.getLogger(SourceTestSuiteBase.class);
+ static ExecutorService executorService =
+ Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors() * 2);
Review comment:
`Runtime.getRuntime().availableProcessors() * 2` is too expensive from my side, and could you add a `private` decoration too.
##########
File path: flink-test-utils-parent/flink-connector-test-utils/src/test/java/org/apache/flink/connector/testframe/utils/TestDataMatchersTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.testframe.utils;
+
+import org.apache.flink.streaming.api.CheckpointingMode;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Nested;
+import org.junit.jupiter.api.Test;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+/** Unit test for {@link TestDataMatchers}. */
+public class TestDataMatchersTest {
Review comment:
Add tests for `CheckpointingMode.AT_LEAST_ONCE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18516:
URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "741b593b95d9501c69f8f7014729b0983350bfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 741b593b95d9501c69f8f7014729b0983350bfe7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org