You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2010/11/01 19:05:00 UTC
Re: svn commit: r1022963 [1/2] - in /harmony/enhanced/java/trunk/classlib/modules/beans: main/ main/java/ main/java/java/ main/java/java/beans/ src/main/java/java/beans/ src/test/java/org/apache/harmony/beans/tests/java/beans/ src/test/resources/xml/
Kevin,
I removed the classlib/modules/beans/main directory accidentally
(?) created by this commit in r1029773. I notice that the two
UtilCollectionsPersistenceDelegate.java files were different. In the
version I deleted the class was public. I assume the non-public version,
that is being used, is correct.
Regards,
Mark.
In message <20...@eris.apache.org>,
zhoukevin@apache.org writes:
>
> Author: zhoukevin
> Date: Fri Oct 15 15:17:01 2010
> New Revision: 1022963
>
> URL: http://svn.apache.org/viewvc?rev=1022963&view=rev
> Log:
> For objects of types generated by methods of java.util.Collections class, lik
> e java.util.Collections$UnmodifiableCollection generated by java.util.Collect
> ions.unmodifiableCollection(Collection) method etc, HARMONY has problem to en
> code and decode them while Oracle JDK doesn't. This patch also adds several t
> est cases to reproduce those problems.
>
> Added:
> harmony/enhanced/java/trunk/classlib/modules/beans/main/
> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/
> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/
> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/beans/
> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/beans/U
> tilCollectionsPersistenceDelegate.java (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
> ns/UtilCollectionsPersistenceDelegate.java (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedCollection.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedRandomAccessList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedSet.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedSortedMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockCheckedSortedSet.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockGetPropertyClass.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockListImplements.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSetImplements.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedCollection.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedRandomAccessList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedSet.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedSortedMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockSynchronizedSortedSet.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableCollection.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableRandomAccessList.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableSet.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableSortedMap.xml (with props)
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
> /MockUnmodifiableSortedSet.xml (with props)
> Modified:
> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
> ns/DefaultPersistenceDelegate.java
> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
> ns/Encoder.java
> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
> ns/XMLEncoder.java
> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/java/org/apac
> he/harmony/beans/tests/java/beans/XMLEncoderTest.java
>
> Added: harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/bean
> s/UtilCollectionsPersistenceDelegate.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/java/trunk/classlib/module
> s/beans/main/java/java/beans/UtilCollectionsPersistenceDelegate.java?rev=1022
> 963&view=auto
>
> [SNIP]
Re: svn commit: r1022963 [1/2] - in /harmony/enhanced/java/trunk/classlib/modules/beans:
main/ main/java/ main/java/java/ main/java/java/beans/ src/main/java/java/beans/
src/test/java/org/apache/harmony/beans/tests/java/beans/ src/test/resources/xml/
Posted by Kevin Zhou <zh...@gmail.com>.
On 2010-11-2 2:05, Mark Hindess wrote:
> Kevin,
>
> I removed the classlib/modules/beans/main directory accidentally
> (?) created by this commit in r1029773. I notice that the two
> UtilCollectionsPersistenceDelegate.java files were different. In the
> version I deleted the class was public. I assume the non-public version,
> that is being used, is correct.
>
> Regards,
> Mark.
>
> In message<20...@eris.apache.org>,
> zhoukevin@apache.org writes:
>> Author: zhoukevin
>> Date: Fri Oct 15 15:17:01 2010
>> New Revision: 1022963
>>
>> URL: http://svn.apache.org/viewvc?rev=1022963&view=rev
>> Log:
>> For objects of types generated by methods of java.util.Collections class, lik
>> e java.util.Collections$UnmodifiableCollection generated by java.util.Collect
>> ions.unmodifiableCollection(Collection) method etc, HARMONY has problem to en
>> code and decode them while Oracle JDK doesn't. This patch also adds several t
>> est cases to reproduce those problems.
>>
>> Added:
>> harmony/enhanced/java/trunk/classlib/modules/beans/main/
>> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/
>> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/
>> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/beans/
>> harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/beans/U
>> tilCollectionsPersistenceDelegate.java (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
>> ns/UtilCollectionsPersistenceDelegate.java (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedCollection.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedRandomAccessList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedSet.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedSortedMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockCheckedSortedSet.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockGetPropertyClass.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockListImplements.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSetImplements.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedCollection.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedRandomAccessList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedSet.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedSortedMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockSynchronizedSortedSet.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableCollection.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableRandomAccessList.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableSet.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableSortedMap.xml (with props)
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/resources/xml
>> /MockUnmodifiableSortedSet.xml (with props)
>> Modified:
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
>> ns/DefaultPersistenceDelegate.java
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
>> ns/Encoder.java
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/main/java/java/bea
>> ns/XMLEncoder.java
>> harmony/enhanced/java/trunk/classlib/modules/beans/src/test/java/org/apac
>> he/harmony/beans/tests/java/beans/XMLEncoderTest.java
>>
>> Added: harmony/enhanced/java/trunk/classlib/modules/beans/main/java/java/bean
>> s/UtilCollectionsPersistenceDelegate.java
>> URL: http://svn.apache.org/viewvc/harmony/enhanced/java/trunk/classlib/module
>> s/beans/main/java/java/beans/UtilCollectionsPersistenceDelegate.java?rev=1022
>> 963&view=auto
>>
>> [SNIP]
>
Yes, Mark. Please remove the public UtilCollectionsPersistenceDelegate
class and save the non-public one. It's out of public api in Java Spec,
just internal implementation for this problem.