You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/08/15 18:44:20 UTC
[jira] [Commented] (GEODE-1782) StatArchiveReader ignores later
stats resource with same name as closed stats resource
[ https://issues.apache.org/jira/browse/GEODE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421455#comment-15421455 ]
ASF subversion and git services commented on GEODE-1782:
--------------------------------------------------------
Commit 9e4f3b5eeb855d45f0d89c3edca9de66fed0384e in incubator-geode's branch refs/heads/feature/GEODE-1781 from [~apache@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9e4f3b5 ]
GEODE-1782: stat resources with different time stamps should not be equal
* StatArchiveWithConsecutiveResourceInstGenerator generates gfs with multiple stat resources of same name but different times
* StatArchiveWithConsecutiveResourceInstIntegrationTest confirms existence of bug GEODE-1782: StatArchiveReader ignores later stats resource with same name as closed stats resource
* ResourceInstTest verifies the underlying issue in StatArchiveReader.ResourceInst.equals and the fix
> StatArchiveReader ignores later stats resource with same name as closed stats resource
> --------------------------------------------------------------------------------------
>
> Key: GEODE-1782
> URL: https://issues.apache.org/jira/browse/GEODE-1782
> Project: Geode
> Issue Type: Bug
> Components: statistics
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> StatArchiveReader ignores later stats resource with same name as closed stats resource.
> The bug is caused by the current implementation of equals in the StatArchiveReader.ResourceInst class. Each of the ResourceInst instances with the same name have different firstTSidx values. The ResourceInst.equals implementation ignores firstTSidx, so StatArchiveReader determines that the ResourceInst instances are equal and ignores the later instances.
> StatArchiveWithConsecutiveResourceInstIntegrationTest confirms the existence of the bug and its fix.
> StatArchiveWithConsecutiveResourceInstGenerator generates a small gfs statistics file containing the values needed to cause StatArchiveReader to hit the bug.
> ResourceInstTest is a new unit test for ResourceInst and confirms the changes for equals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)