You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/19 19:08:36 UTC
[GitHub] [pinot] richardstartin opened a new pull request #7599: use StandardCharsets.UTF_8
richardstartin opened a new pull request #7599:
URL: https://github.com/apache/pinot/pull/7599
## Description
Modernise `StringUtils` - use `StandardCharsets` which is faster (I can demonstrate this if necessary).
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #7599:
URL: https://github.com/apache/pinot/pull/7599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947087554
I have some data from last time I went through this particular exercise - let me clean it up to demonstrate this is beneficial for anyone using JDK9+ (later this week)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947817242
@richardstartin thanks for the diligence and detailed benchmark results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947044902
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7599](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1aadd2) into [master](https://codecov.io/gh/apache/pinot/commit/85e0d9e4f32df0cbcfbaa03cd123164506bb7139?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85e0d9e) will **decrease** coverage by `5.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7599 +/- ##
============================================
- Coverage 70.32% 65.15% -5.17%
- Complexity 3882 3890 +8
============================================
Files 1552 1506 -46
Lines 79012 77157 -1855
Branches 11705 11505 -200
============================================
- Hits 55562 50275 -5287
- Misses 19644 23317 +3673
+ Partials 3806 3565 -241
```
| Flag | Coverage Δ | |
|---|---|---|
| integration2 | `?` | |
| unittests1 | `68.64% <100.00%> (+0.08%)` | :arrow_up: |
| unittests2 | `14.70% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pinot/spi/utils/StringUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `100.00% <100.00%> (+57.14%)` | :arrow_up: |
| [...a/org/apache/pinot/common/metrics/MinionMeter.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/pinot/common/messages/SegmentReloadMessage.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvU2VnbWVudFJlbG9hZE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/core/data/manager/realtime/TimerService.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvVGltZXJTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...not/common/exception/HttpErrorStatusException.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL0h0dHBFcnJvclN0YXR1c0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t/core/startree/plan/StarTreeDocIdSetPlanNode.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlRG9jSWRTZXRQbGFuTm9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ot/common/restlet/resources/TableMetadataInfo.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVNZXRhZGF0YUluZm8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [321 more](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85e0d9e...a1aadd2](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947070413
I had found this to result in more garbage before.
https://github.com/apache/pinot/pull/3073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947044902
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7599](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2817d4) into [master](https://codecov.io/gh/apache/pinot/commit/4246e0f2b1dfb6ed387d584002d70a226f6fcd91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4246e0f) will **decrease** coverage by `1.23%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7599 +/- ##
============================================
- Coverage 71.56% 70.33% -1.24%
- Complexity 3881 3882 +1
============================================
Files 1559 1559
Lines 79053 79049 -4
Branches 11706 11706
============================================
- Hits 56575 55598 -977
- Misses 18669 19648 +979
+ Partials 3809 3803 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `27.89% <0.00%> (-0.03%)` | :arrow_down: |
| unittests1 | `68.58% <100.00%> (+<0.01%)` | :arrow_up: |
| unittests2 | `14.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pinot/spi/utils/StringUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `100.00% <100.00%> (+57.14%)` | :arrow_up: |
| [...pinot/minion/exception/TaskCancelledException.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhjZXB0aW9uL1Rhc2tDYW5jZWxsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nverttorawindex/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1taW5pb24tdGFza3MvcGlub3QtbWluaW9uLWJ1aWx0aW4tdGFza3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3BsdWdpbi9taW5pb24vdGFza3MvY29udmVydHRvcmF3aW5kZXgvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/pinot/common/minion/MergeRollupTaskMetadata.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWluaW9uL01lcmdlUm9sbHVwVGFza01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| [...plugin/segmentuploader/SegmentUploaderDefault.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1zZWdtZW50LXVwbG9hZGVyL3Bpbm90LXNlZ21lbnQtdXBsb2FkZXItZGVmYXVsdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL3NlZ21lbnR1cGxvYWRlci9TZWdtZW50VXBsb2FkZXJEZWZhdWx0LmphdmE=) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
| [...ore/startree/executor/StarTreeGroupByExecutor.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9leGVjdXRvci9TdGFyVHJlZUdyb3VwQnlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-85.30%)` | :arrow_down: |
| [...ot/common/messages/RoutingTableRebuildMessage.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvUm91dGluZ1RhYmxlUmVidWlsZE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ache/pinot/common/lineage/SegmentLineageUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbGluZWFnZS9TZWdtZW50TGluZWFnZVV0aWxzLmphdmE=) | `22.22% <0.00%> (-77.78%)` | :arrow_down: |
| [...verttorawindex/ConvertToRawIndexTaskGenerator.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1taW5pb24tdGFza3MvcGlub3QtbWluaW9uLWJ1aWx0aW4tdGFza3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3BsdWdpbi9taW5pb24vdGFza3MvY29udmVydHRvcmF3aW5kZXgvQ29udmVydFRvUmF3SW5kZXhUYXNrR2VuZXJhdG9yLmphdmE=) | `8.77% <0.00%> (-77.20%)` | :arrow_down: |
| ... and [98 more](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4246e0f...f2817d4](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947044902
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7599](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1aadd2) into [master](https://codecov.io/gh/apache/pinot/commit/85e0d9e4f32df0cbcfbaa03cd123164506bb7139?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85e0d9e) will **decrease** coverage by `55.61%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7599 +/- ##
=============================================
- Coverage 70.32% 14.70% -55.62%
+ Complexity 3882 80 -3802
=============================================
Files 1552 1506 -46
Lines 79012 77157 -1855
Branches 11705 11505 -200
=============================================
- Hits 55562 11347 -44215
- Misses 19644 64997 +45353
+ Partials 3806 813 -2993
```
| Flag | Coverage Δ | |
|---|---|---|
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.70% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pinot/spi/utils/StringUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/core/data/table/BaseTable.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0Jhc2VUYWJsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1202 more](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85e0d9e...a1aadd2](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947183264
This benchmark demonstrates the improvement on JDK11 and also that the implementation was sensible on JDK8. It uses 4 different character types, to generate all 4 possible lengths of UTF8 sequence:
```java
@State(Scope.Benchmark)
public class DecodingBenchmark {
@Param({"1", "10", "100", "1000"})
int length;
@Param({"a", "ß", "道", "\uD841\uDF0E"})
String unit;
private String data;
@Setup(Level.Trial)
public void setup() {
StringBuilder sb = new StringBuilder(length * unit.length());
for (int i = 0; i < length; i++) {
sb.append(unit);
}
this.data = sb.toString();
}
@Benchmark
public byte[] decodeUTF8Charset() {
return data.getBytes(StandardCharsets.UTF_8);
}
@Benchmark
public byte[] decodeUTF8CharsetName() {
try {
return data.getBytes("UTF-8");
} catch (UnsupportedEncodingException e) {
throw new RuntimeException(e);
}
}
}
```
JDK11: pay attention to both the avgt (better even for quite long strings) and the normalised allocation rate (always the same)
```
Benchmark (length) (unit) Mode Cnt Score Error Units
DecodingBenchmark.decodeUTF8Charset 1 a avgt 5 12.690 ± 0.290 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 a avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 ß avgt 5 19.147 ± 0.128 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 ß avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 道 avgt 5 15.301 ± 0.047 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 𠜎 avgt 5 30.449 ± 0.280 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 a avgt 5 13.916 ± 0.212 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 a avgt 5 32.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 ß avgt 5 27.862 ± 0.246 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 ß avgt 5 40.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 道 avgt 5 54.348 ± 1.026 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 𠜎 avgt 5 87.956 ± 0.600 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 17.833 ± 0.228 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 ß avgt 5 162.337 ± 0.883 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 ß avgt 5 216.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 道 avgt 5 441.978 ± 2.089 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 𠜎 avgt 5 654.704 ± 2.691 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 a avgt 5 143.401 ± 2.833 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 a avgt 5 1016.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 ß avgt 5 1953.952 ± 18.583 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 ß avgt 5 2016.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 道 avgt 5 4340.205 ± 168.275 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 𠜎 avgt 5 6668.428 ± 71.027 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 a avgt 5 35.770 ± 0.594 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 a avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 ß avgt 5 34.974 ± 0.464 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 ß avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 道 avgt 5 34.873 ± 0.927 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 𠜎 avgt 5 49.799 ± 2.304 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 a avgt 5 38.018 ± 0.273 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 a avgt 5 32.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 ß avgt 5 51.948 ± 0.146 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 ß avgt 5 40.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 道 avgt 5 72.474 ± 0.840 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 𠜎 avgt 5 107.176 ± 0.275 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 39.540 ± 0.426 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 ß avgt 5 184.251 ± 1.008 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 ß avgt 5 216.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 道 avgt 5 457.615 ± 0.749 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 𠜎 avgt 5 672.385 ± 17.598 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 a avgt 5 142.672 ± 2.752 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 a avgt 5 1016.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 ß avgt 5 1600.567 ± 7.064 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 ß avgt 5 2016.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 道 avgt 5 4388.180 ± 48.504 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 𠜎 avgt 5 6663.150 ± 60.651 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
```
Just compare any pair with the same parameters. E.g. for a 100 char ASCII string, there is no extra allocation but the time is halved:
```
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 17.833 ± 0.228 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 39.540 ± 0.426 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
```
On JDK8, the avgt is much higher but more is allocated when using `StandardCharsets`
```
Benchmark (length) (unit) Mode Cnt Score Error Units
DecodingBenchmark.decodeUTF8Charset 1 a avgt 5 58.534 ± 0.758 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 a avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 ß avgt 5 65.887 ± 1.033 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 ß avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 道 avgt 5 57.018 ± 1.035 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 道 avgt 5 128.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 𠜎 avgt 5 77.302 ± 2.559 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 𠜎 avgt 5 176.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 a avgt 5 65.488 ± 0.488 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 a avgt 5 184.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 ß avgt 5 85.795 ± 1.593 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 ß avgt 5 192.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 道 avgt 5 84.273 ± 1.305 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 道 avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 𠜎 avgt 5 137.654 ± 1.435 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 𠜎 avgt 5 264.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 136.765 ± 2.063 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 544.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 ß avgt 5 289.917 ± 4.506 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 ß avgt 5 640.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 道 avgt 5 371.064 ± 1.888 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 道 avgt 5 424.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 𠜎 avgt 5 812.540 ± 13.020 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 𠜎 avgt 5 1160.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 a avgt 5 1067.417 ± 24.818 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 a avgt 5 4136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 ß avgt 5 2618.408 ± 38.177 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 ß avgt 5 5136.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 道 avgt 5 3433.173 ± 32.028 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 道 avgt 5 3120.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 𠜎 avgt 5 7883.986 ± 79.200 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10160.003 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 a avgt 5 55.946 ± 0.497 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 a avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 ß avgt 5 61.014 ± 2.516 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 ß avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 道 avgt 5 56.231 ± 0.289 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 𠜎 avgt 5 74.309 ± 1.246 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 a avgt 5 61.794 ± 0.312 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 a avgt 5 80.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 ß avgt 5 84.202 ± 0.701 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 ß avgt 5 88.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 道 avgt 5 84.276 ± 0.999 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 𠜎 avgt 5 133.305 ± 1.293 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 133.185 ± 2.087 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 440.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 ß avgt 5 248.623 ± 3.828 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 ß avgt 5 536.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 道 avgt 5 372.915 ± 14.813 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 𠜎 avgt 5 820.216 ± 82.970 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 a avgt 5 1066.354 ± 83.986 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 a avgt 5 4032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 ß avgt 5 2700.836 ± 190.698 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 ß avgt 5 5032.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 道 avgt 5 3466.882 ± 288.632 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 𠜎 avgt 5 7986.518 ± 359.135 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947074571
> I had found this to result in more garbage before.
>
> #3073
@mcvsubbu this is only an issue on JDK8; this part of the JDK was mostly reimplemented since then. Please see the linked JDK PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947044902
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7599](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1aadd2) into [master](https://codecov.io/gh/apache/pinot/commit/85e0d9e4f32df0cbcfbaa03cd123164506bb7139?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85e0d9e) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7599 +/- ##
============================================
+ Coverage 70.32% 70.37% +0.05%
- Complexity 3882 3890 +8
============================================
Files 1552 1552
Lines 79012 79008 -4
Branches 11705 11705
============================================
+ Hits 55562 55599 +37
+ Misses 19644 19613 -31
+ Partials 3806 3796 -10
```
| Flag | Coverage Δ | |
|---|---|---|
| integration2 | `27.80% <0.00%> (-0.04%)` | :arrow_down: |
| unittests1 | `68.64% <100.00%> (+0.08%)` | :arrow_up: |
| unittests2 | `14.70% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pinot/spi/utils/StringUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `100.00% <100.00%> (+57.14%)` | :arrow_up: |
| [...y/aggregation/function/MaxAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9NYXhBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `97.22% <0.00%> (-2.78%)` | :arrow_down: |
| [...y/aggregation/function/AvgAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BdmdBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `94.73% <0.00%> (-2.64%)` | :arrow_down: |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `72.00% <0.00%> (-1.02%)` | :arrow_down: |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `66.66% <0.00%> (-0.82%)` | :arrow_down: |
| [...ache/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvWktNZXRhZGF0YVByb3ZpZGVyLmphdmE=) | `77.44% <0.00%> (-0.76%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `87.87% <0.00%> (-0.54%)` | :arrow_down: |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `70.37% <0.00%> (-0.22%)` | :arrow_down: |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `71.25% <0.00%> (-0.14%)` | :arrow_down: |
| [...cal/startree/v2/builder/BaseSingleTreeBuilder.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zdGFydHJlZS92Mi9idWlsZGVyL0Jhc2VTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `89.18% <0.00%> (+0.90%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85e0d9e...a1aadd2](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin edited a comment on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin edited a comment on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947183264
This benchmark demonstrates the improvement on JDK11 and also that the implementation was sensible on JDK8. It uses 4 different character types, to generate all 4 possible lengths of UTF8 sequence:
```java
@State(Scope.Benchmark)
public class DecodingBenchmark {
@Param({"1", "10", "100", "1000"})
int length;
@Param({"a", "ß", "道", "\uD841\uDF0E"})
String unit;
private String data;
@Setup(Level.Trial)
public void setup() {
StringBuilder sb = new StringBuilder(length * unit.length());
for (int i = 0; i < length; i++) {
sb.append(unit);
}
this.data = sb.toString();
}
@Benchmark
public byte[] decodeUTF8Charset() {
return data.getBytes(StandardCharsets.UTF_8);
}
@Benchmark
public byte[] decodeUTF8CharsetName() {
try {
return data.getBytes("UTF-8");
} catch (UnsupportedEncodingException e) {
throw new RuntimeException(e);
}
}
}
```
JDK11: pay attention to both the avgt (better even for quite long strings) and the normalised allocation rate (always the same)
```
Benchmark (length) (unit) Mode Cnt Score Error Units
DecodingBenchmark.decodeUTF8Charset 1 a avgt 5 12.690 ± 0.290 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 a avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 ß avgt 5 19.147 ± 0.128 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 ß avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 道 avgt 5 15.301 ± 0.047 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 𠜎 avgt 5 30.449 ± 0.280 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 a avgt 5 13.916 ± 0.212 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 a avgt 5 32.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 ß avgt 5 27.862 ± 0.246 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 ß avgt 5 40.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 道 avgt 5 54.348 ± 1.026 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 𠜎 avgt 5 87.956 ± 0.600 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 17.833 ± 0.228 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 ß avgt 5 162.337 ± 0.883 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 ß avgt 5 216.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 道 avgt 5 441.978 ± 2.089 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 𠜎 avgt 5 654.704 ± 2.691 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 a avgt 5 143.401 ± 2.833 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 a avgt 5 1016.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 ß avgt 5 1953.952 ± 18.583 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 ß avgt 5 2016.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 道 avgt 5 4340.205 ± 168.275 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 𠜎 avgt 5 6668.428 ± 71.027 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 a avgt 5 35.770 ± 0.594 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 a avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 ß avgt 5 34.974 ± 0.464 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 ß avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 道 avgt 5 34.873 ± 0.927 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 𠜎 avgt 5 49.799 ± 2.304 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 a avgt 5 38.018 ± 0.273 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 a avgt 5 32.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 ß avgt 5 51.948 ± 0.146 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 ß avgt 5 40.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 道 avgt 5 72.474 ± 0.840 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 𠜎 avgt 5 107.176 ± 0.275 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 39.540 ± 0.426 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 ß avgt 5 184.251 ± 1.008 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 ß avgt 5 216.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 道 avgt 5 457.615 ± 0.749 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 𠜎 avgt 5 672.385 ± 17.598 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 a avgt 5 142.672 ± 2.752 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 a avgt 5 1016.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 ß avgt 5 1600.567 ± 7.064 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 ß avgt 5 2016.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 道 avgt 5 4388.180 ± 48.504 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 𠜎 avgt 5 6663.150 ± 60.651 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
```
Just compare any pair with the same parameters. E.g. for a 100 char ASCII string, there is no extra allocation but the time is halved:
```
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 17.833 ± 0.228 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 39.540 ± 0.426 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
```
On JDK8, the avgt is much higher but more is allocated when using `StandardCharsets`
```
Benchmark (length) (unit) Mode Cnt Score Error Units
DecodingBenchmark.decodeUTF8Charset 1 a avgt 5 58.534 ± 0.758 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 a avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 ß avgt 5 65.887 ± 1.033 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 ß avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 道 avgt 5 57.018 ± 1.035 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 道 avgt 5 128.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1 𠜎 avgt 5 77.302 ± 2.559 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1 𠜎 avgt 5 176.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 a avgt 5 65.488 ± 0.488 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 a avgt 5 184.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 ß avgt 5 85.795 ± 1.593 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 ß avgt 5 192.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 道 avgt 5 84.273 ± 1.305 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 道 avgt 5 152.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 10 𠜎 avgt 5 137.654 ± 1.435 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 10 𠜎 avgt 5 264.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 136.765 ± 2.063 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 544.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 ß avgt 5 289.917 ± 4.506 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 ß avgt 5 640.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 道 avgt 5 371.064 ± 1.888 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 道 avgt 5 424.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 100 𠜎 avgt 5 812.540 ± 13.020 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 𠜎 avgt 5 1160.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 a avgt 5 1067.417 ± 24.818 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 a avgt 5 4136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 ß avgt 5 2618.408 ± 38.177 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 ß avgt 5 5136.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 道 avgt 5 3433.173 ± 32.028 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 道 avgt 5 3120.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8Charset 1000 𠜎 avgt 5 7883.986 ± 79.200 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10160.003 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 a avgt 5 55.946 ± 0.497 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 a avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 ß avgt 5 61.014 ± 2.516 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 ß avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 道 avgt 5 56.231 ± 0.289 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 道 avgt 5 24.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1 𠜎 avgt 5 74.309 ± 1.246 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1 𠜎 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 a avgt 5 61.794 ± 0.312 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 a avgt 5 80.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 ß avgt 5 84.202 ± 0.701 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 ß avgt 5 88.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 道 avgt 5 84.276 ± 0.999 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 道 avgt 5 48.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 10 𠜎 avgt 5 133.305 ± 1.293 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 10 𠜎 avgt 5 136.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 133.185 ± 2.087 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 440.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 ß avgt 5 248.623 ± 3.828 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 ß avgt 5 536.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 道 avgt 5 372.915 ± 14.813 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 道 avgt 5 320.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 𠜎 avgt 5 820.216 ± 82.970 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 𠜎 avgt 5 1032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 a avgt 5 1066.354 ± 83.986 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 a avgt 5 4032.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 ß avgt 5 2700.836 ± 190.698 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 ß avgt 5 5032.001 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 道 avgt 5 3466.882 ± 288.632 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 道 avgt 5 3016.002 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 1000 𠜎 avgt 5 7986.518 ± 359.135 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 1000 𠜎 avgt 5 10032.003 ± 0.001 B/op
```
For the same 100 char ASCII string mentioned above, the user would be better off upgrading their JVM than relying on this optimisation:
JDK11
```
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 17.833 ± 0.228 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 39.540 ± 0.426 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 120.000 ± 0.001 B/op
```
JDK8
```
DecodingBenchmark.decodeUTF8Charset 100 a avgt 5 136.765 ± 2.063 ns/op
DecodingBenchmark.decodeUTF8Charset:·gc.alloc.rate.norm 100 a avgt 5 544.000 ± 0.001 B/op
DecodingBenchmark.decodeUTF8CharsetName 100 a avgt 5 133.185 ± 2.087 ns/op
DecodingBenchmark.decodeUTF8CharsetName:·gc.alloc.rate.norm 100 a avgt 5 440.000 ± 0.001 B/op
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947183699
@Jackie-Jiang would you mind rerunning the tests (and taking a look)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947044902
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7599](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2817d4) into [master](https://codecov.io/gh/apache/pinot/commit/4246e0f2b1dfb6ed387d584002d70a226f6fcd91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4246e0f) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7599 +/- ##
============================================
+ Coverage 71.56% 71.63% +0.06%
- Complexity 3881 3882 +1
============================================
Files 1559 1559
Lines 79053 79049 -4
Branches 11706 11706
============================================
+ Hits 56575 56627 +52
+ Misses 18669 18607 -62
- Partials 3809 3815 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.55% <0.00%> (+0.28%)` | :arrow_up: |
| integration2 | `27.89% <0.00%> (-0.03%)` | :arrow_down: |
| unittests1 | `68.58% <100.00%> (+<0.01%)` | :arrow_up: |
| unittests2 | `14.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pinot/spi/utils/StringUtils.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `100.00% <100.00%> (+57.14%)` | :arrow_up: |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGVjdXRvci9TZXJ2ZXJRdWVyeUV4ZWN1dG9yVjFJbXBsLmphdmE=) | `82.32% <0.00%> (-4.98%)` | :arrow_down: |
| [...pinot/core/query/request/context/TimerContext.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvVGltZXJDb250ZXh0LmphdmE=) | `91.66% <0.00%> (-4.17%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/data/TimeFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9UaW1lRmllbGRTcGVjLmphdmE=) | `88.63% <0.00%> (-2.28%)` | :arrow_down: |
| [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `78.02% <0.00%> (-2.20%)` | :arrow_down: |
| [...core/startree/operator/StarTreeFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9vcGVyYXRvci9TdGFyVHJlZUZpbHRlck9wZXJhdG9yLmphdmE=) | `86.52% <0.00%> (-2.13%)` | :arrow_down: |
| [...ation/function/MinMaxRangeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9NaW5NYXhSYW5nZUFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `87.50% <0.00%> (-1.25%)` | :arrow_down: |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `72.00% <0.00%> (-1.02%)` | :arrow_down: |
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `75.60% <0.00%> (-0.82%)` | :arrow_down: |
| [...lix/core/minion/PinotHelixTaskResourceManager.java](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9QaW5vdEhlbGl4VGFza1Jlc291cmNlTWFuYWdlci5qYXZh) | `44.18% <0.00%> (-0.78%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/pinot/pull/7599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4246e0f...f2817d4](https://codecov.io/gh/apache/pinot/pull/7599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947530785
The tests really do need a rerun this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on pull request #7599: use StandardCharsets.UTF_8
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #7599:
URL: https://github.com/apache/pinot/pull/7599#issuecomment-947079324
I have not read the entire JDK PRs, but it talks only about speed. Our problem (at the time) was specifically GC overhead in realtime when segments were being built. The result was query performance suffered.
Can you make any memory usage comparisons across these two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org