You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/02 18:59:49 UTC

[GitHub] [incubator-superset] john-bodley commented on issue #8828: Do we really need four different Python linters?

john-bodley commented on issue #8828: Do we really need four different Python linters?
URL: https://github.com/apache/incubator-superset/issues/8828#issuecomment-570306810
 
 
   As @willbarrett pointed out these four linters all provide different linting functionality from code formatting, type checking, and flagging programatic errors. Personally I would love for `black` to be opinionated with regards to imports which would remove the need to use `isort`. 
    
   As @mistercrunch mentioned `pylint` is dynamic and provides functionality that `flake8` never could. I sense that `black` + `isort` + `mypy` + `pylint` is a superset of `flake8` hence why `flake8` was removed. `pylint` has its detractors and at times it feels somewhat dated but personally I'm a fan. The signature checking is vital and the syntax checks generally make sense which aid with code quality.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org