You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/08 07:59:44 UTC

[GitHub] [rocketmq] tianliuliu opened a new issue #3604: Some important interface methods are not commented

tianliuliu opened a new issue #3604:
URL: https://github.com/apache/rocketmq/issues/3604


   in /rocketmq/store/src/main/java/org/apache/rocketmq/store/CommitLogDispatcher.java
   and /rocketmq/store/src/main/java/org/apache/rocketmq/store/MessageArrivingListener.java
   ```java
   public interface CommitLogDispatcher {
       // should some comment here
       void dispatch(final DispatchRequest request);
   }
   ```
   
   ```java
   public interface MessageArrivingListener {
       // should some comment here
       void arriving(String topic, int queueId, long logicOffset, long tagsCode,
           long msgStoreTime, byte[] filterBitMap, Map<String, String> properties);
   }
   ```
   These important interface methods are not commented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3604: Some important interface methods are not commented

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3604:
URL: https://github.com/apache/rocketmq/issues/3604#issuecomment-988595872


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3604: Some important interface methods are not commented

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3604:
URL: https://github.com/apache/rocketmq/issues/3604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org