[jira] [Commented] (PDFBOX-1798) Performance problem with PDDocument.saveIncremental (when signing document)

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169803#comment-14169803 ] 

ASF subversion and git services commented on PDFBOX-1798:
---------------------------------------------------------

Commit 1631519 from [~tilman] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1631519 ]

PDFBOX-1798: use base class to allow performance optimization, as suggested by Dmytro Karimov

> Performance problem with PDDocument.saveIncremental (when signing document)
> ---------------------------------------------------------------------------
>
>                 Key: PDFBOX-1798
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1798
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Signing, Writing
>    Affects Versions: 1.8.3, 2.0.0
>            Reporter: Dmytro Karimov
>              Labels: patch, performance
>             Fix For: 2.0.0
>
>         Attachments: PDFBOX-1798.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Performance problem in class COSWriter:
> Constructor of COSWriter takes 2 args:
>         COSWriter(OutputStream os, FileInputStream is)
> method saveIncremental in class PDDocument:
>         saveIncremental(FileInputStream input, OutputStream output)
> It create COSWriter with this args. If I pass FileInputStream into saveIncremental then signing the document goes quite a long time.
> If you pass BufferedInputStream, the signing speed is increases. But alas, this is not possible, because the parameters of the method saveIncremental does not allow to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)