[GitHub] [beam] pabloem commented on a change in pull request #14104: Add write method to python WriteToBigQuery display data

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #14104:
URL: https://github.com/apache/beam/pull/14104#discussion_r592771062



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1774,6 +1773,9 @@ def display_data(self):
       if self.table_reference.projectId is not None:
         tableSpec = '{}:{}'.format(self.table_reference.projectId, tableSpec)
       res['table'] = DisplayDataItem(tableSpec, label='Table')
+    method = self._compute_method(False) # TODO is there a way to get if its streaming at job launch time?
+    res['method'] = DisplayDataItem(

Review comment:
       perhaps you should just use `self.method` here, so that we can at least see DEFAULT, FILE_LOADS or STREAMING_INSERTS. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org